Add new function for getting the value of specific key in htable. if the key was expired, the type parameter's value will be set minus one.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1866
-- Commit Summary --
* htable: Add new function into htable_api
-- File Changes --
M src/modules/htable/api.c (14) M src/modules/htable/api.h (3) M src/modules/htable/ht_api.c (45) M src/modules/htable/ht_api.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1866.patch https://github.com/kamailio/kamailio/pull/1866.diff
It doesn't seem safe what you do there, because you copy the value of the item in a new variable, then unlock the slot. But the value can be a string and that will point in share memory. By unlocking, the item in hash table can be deleted or modified, making the previous string value invalid.
See how is the function for pv get of $sht(...), there is a deep cloning of the item.
I got it. I will update it just as it had done in $sht(...).
On Mon, Feb 25, 2019 at 2:45 PM Daniel-Constantin Mierla < notifications@github.com> wrote:
It doesn't seem safe what you do there, because you copy the value of the item in a new variable, then unlock the slot. But the value can be a string and that will point in share memory. By unlocking, the item in hash table can be deleted or modified, making the previous string value invalid.
See how is the function for pv get of $sht(...), there is a deep cloning of the item.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1866#issuecomment-466973400, or mute the thread https://github.com/notifications/unsubscribe-auth/ArE2rFNa0SskW3IB0Pc8LulNFOoGAfHrks5vQ8XfgaJpZM4bPk66 .
@mojtabaesfandiari pushed 1 commit.
a4ba33b12fdf16cdb9c5cfee4346823fb4096df6 htable: some changes in ht_get_cell function
I pushed a different patch, the way you kept reference to _ht_local in ht_cell_get() was lost, because the variable was on stack. Then it was no need for two layers of wrapper functions, both being small. The api function member is named `get_clone` to be clear is not the htable cell pointer. The result has to be pkg_free() after use. Commit is referenced above.
Closed #1866.
-
Daniel-Constantin Mierla -
mojtabaesfandiari