When set_rtpengine_set() config function is called.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> After calling set_rtpengine_set(), the new set is not set for further rtpengine delete(). This is because active_rtpp_set is set to default_rtpp_set when msg id != current_msg_id (which is set once by set_rtpengine_set())
I've removed the msg id != current_msg_id condition, and initialized active_rtpp_set in mod_init().
Basically tested locally with 2 sets with 1 rtpengine each. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2965
-- Commit Summary --
* rtpengine: Fix set selection
-- File Changes --
M src/modules/rtpengine/rtpengine.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2965.patch https://github.com/kamailio/kamailio/pull/2965.diff
At the first sight, does not seem good.
That protection with msg_id is to ensure that a rtpengine group (set) is used only for the SIP message it was set for.
Now it seems you remove that protection and setting a rtpengine group stays until is set again.
Anyhow, the end of the call (BYE) can be handled by a different SIP worker process than the one which handled the corresponding INVITE, so you can't really have (expect) the rtpengine group to be set to same value from INVITE till BYE. You should store it inside a dlg variable (if you use dialog module) or in a hashtable. It is also an option to add it as a param to record-route header.
Thank you for the feedback! Closing this PR.
Closed #2965.