With this patch drouting can use "#*+" in addition to the decimal digits. ### Some tests with a set of 500.000 rules (64bit system) #### Performance impact (kamcmd droating.reload): decimal only: ~21sec decimal and "#*+": ~21sec #### Memory usage (kamcmd core.shmmem): after start, decimal only, used: 203119976 after start, decimal and "#*+", used: 240338888 You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/194
-- Commit Summary --
* Add symbols "#*+" to drouting tree
-- File Changes --
M modules/drouting/prefix_tree.c (61) M modules/drouting/prefix_tree.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/194.patch https://github.com/kamailio/kamailio/pull/194.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/194
The code to compute the index is repeating in 3 places. It should be made a function. You can add an addition patch to this pull request and I will merge then.
In long term, the list of characters that can be used has to be made a module parameter, for proper flexibility.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/194#issuecomment-111114625
or you can rework the patch amend and push --force
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/194#issuecomment-111115220
uniform code is moved to function.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/194#issuecomment-111968419
I am going to merge it.
For the future, when writing the commit messages, use the guidelines from:
* http://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/194#issuecomment-111995565
Merged #194.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/194#event-330838316