Hi Daniel,
in this case it was a rarely update file so I thought it would be
better. I of course checked it to not push any other files.
But I agree, it better to generate the README in the own repository and
then let the format be "fixed" by the first update by the script.
Cheers,
Henning
Am 15.08.19 um 08:48 schrieb Daniel-Constantin Mierla:
Hello,
the first version of the README should be added by a developer (the one
that wrote the xml files or someone else with commit access) -- it it is
a different format, it will be "fixed" with the first update.
First is about knowing the ownership of each file in the repository
(i.e., for the cases when licensing or other matters need to be sorted
out), then also the Kamailio Dev is acting via a cron.d job and such
automating scripts should not add new files, because it can add by
mistake files that should not be pushed to the public repository (like
temporary files of the editors or other files that can be in the folder
due to maintenance work at a specific point in time, which may contain
sensitive data).
Cheers,
Daniel
On 15.08.19 08:25, Henning Westerholt wrote:
> Hi Daniel,
>
> the README was missing (related to GH #1644) , so I added it there to
> have the correct syntax. If I generated on my PC it looks differently.
>
> Cheers,
>
> Henning
>
> Am 15.08.19 um 08:10 schrieb Daniel-Constantin Mierla:
>> Wondering why Kamailio Dev is adding files to the repository. It is
>> supposed to only update existing README files ...
>>
>> Cheers,
>> Daniel
>>
>> On 14.08.19 19:39, Kamailio Dev wrote:
>>> Module: kamailio
>>> Branch: 5.2
>>> Commit: 6670a3b6403fb43670042103ce4e087f92fa0c1b
>>> URL:
https://github.com/kamailio/kamailio/commit/6670a3b6403fb43670042103ce4e087…
>>>
>>> Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
>>> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
>>> Date: 2019-08-14T19:37:37+02:00
>>>
>>> add ims_usrloc_scscf README
>>>
>>> ---
>>>
>>> Added: src/modules/ims_usrloc_scscf/README
>>>
>>> ---
>>>
>>> Diff:
https://github.com/kamailio/kamailio/commit/6670a3b6403fb43670042103ce4e087…
>>> Patch:
https://github.com/kamailio/kamailio/commit/6670a3b6403fb43670042103ce4e087…
>>>
>>>
>>> _______________________________________________
>>> Kamailio (SER) - Development Mailing List
>>> sr-dev(a)lists.kamailio.org
>>>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev