success events should be routed to onreply_route[] failure events should be routed to failure_route[]
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Kazoo cfg files use onreply_route[] and failure_route[] to handle the replies from AMQP and the module was sending the replies to the main route and therefore the scripts were not receiving the responses You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2786
-- Commit Summary --
* kazoo : fix routing of reply events
-- File Changes --
M src/modules/kazoo/kz_amqp.c (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2786.patch https://github.com/kamailio/kamailio/pull/2786.diff
Thanks for the pull-request. @lazedo any comments from your side to it?
let me test this PR.
I have tested this PR. Looks as when `registrar` response returns an error then Kamailio properly handles this response.
I have tested this PR. Looks as when `registrar` response returns an error then Kamailio properly handles this response.
@sergey-safarov I'm sorry I don't know what you mean by this comment, do you agree that this fix is required? I'm using the 2600hz kamailio configuration to do the validation https://github.com/2600hz/kazoo-configs-kamailio/blob/4.3/kamailio/registrar...
Hi @kageds Think I misled in the message above. My issue because I try to use the latest `kazoo-config-kamailio` with old "kazoo erlang" code. Please ignore my message above.
+1 one here! @lazedo would love your opinion/blessing!
@lazedo - pinging again, any comments on this PR? Anyone else? If no feedback in near future, I assume it can be merged.
Merging, if anything needs to be changed, other commits can follow up.
Merged #2786 into master.