<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description This commits adding some new functions to Get and Change forwarding info in ISUP part of SIP-I/SIP-T messages.
sipt_forwarding(origin, nai) - updates the IAM in the body if it exists, setting (or adding) the forwarding number to origin with the nature address specified in nai
$sipt_redirection_info - Returns "Redirecting reason" or -1 if no redirection info found.
$sipt_redirection_number - Returns number to which redirection will trigered
sipt_redirection_number_nai - Returns NAI for redirection number from ISUP
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1498
-- Commit Summary --
* sipt: Add functions to work with forwarding info (#18)
-- File Changes --
M src/modules/sipt/doc/sipt_admin.xml (72) M src/modules/sipt/sipt.c (149) M src/modules/sipt/ss7.h (6) M src/modules/sipt/ss7_parser.c (138)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1498.patch https://github.com/kamailio/kamailio/pull/1498.diff
I think it would be good to have one variable class with inner names instead of many new variables, eventually added to the existing $sipt(...) variable -- maybe @tsearle can comment more.
@sergey-vb - would you consider having the new variables as part of $sipt(...)?
So instead of:
``` $sipt_redirection_info $sipt_redirection_number_nai $sipt_redirection_number ```
To have:
``` $sipt(redirection_info) $sipt(redirection_number_nai) $sipt(redirection_number) ```
I think it is better to have them grouped. You can push a new patch for it, no need to do a new PR. Then I can merge.
Hi Daniel, I will try to do this.
-- Best regards, Sergey Basov e-mail: sergey.v.basov@gmail.com
2018-04-25 15:57 GMT+03:00 Daniel-Constantin Mierla < notifications@github.com>:
@sergey-vb https://github.com/sergey-vb - would you consider having the new variables as part of $sipt(...)?
So instead of:
$sipt_redirection_info $sipt_redirection_number_nai $sipt_redirection_number
To have:
$sipt(redirection_info) $sipt(redirection_number_nai) $sipt(redirection_number)
I think it is better to have them grouped. You can push a new patch for it, no need to do a new PR. Then I can merge.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1498#issuecomment-384276779, or mute the thread https://github.com/notifications/unsubscribe-auth/ARTPaxobYA4a77iPiq1jMOCs67E4hwKkks5tsHKjgaJpZM4TR8HV .
Any estimation when you are going to work on updating the variables. I am reviewing the PRs in order to merge what's ready.
In progress. I have some problem with returning number from sipt_get_redirection_number function. I can print it in c code using LM_INFO("REDIRECTION NUMBER : %s end \n", sb_s.s);
But when i do pv_get_strval(msg, param, res, &sb_s); I got some binary value in kamailio script.
@sergey-vb pushed 1 commit.
4408cbf New variables as part of $sipt(...)
@sergey-vb pushed 1 commit.
2cbac29 Documenting new variables as part of $sipt(...)
Hi Daniel.
I have done adding new variables as a part of $sipt() Now they are: $sipt(redirection_info) $sipt(redirection_number) $sipt(redirection_number.nai)
@sergey-vb pushed 1 commit.
0030113 sipt: remove some debugging info
Thanks, merged manually via 21b9694d4eb18e146692dedc2a2337216d58b5c2 .
The vars exported not part of $sipt(...) were removed.
Closed #1498.
-
Daniel-Constantin Mierla -
Sergey Basov
-
sergey-vb