I tried latest Linphone and when it tried to register, K complained:
Sep 13 20:56:06 box /usr/bin/sip-proxy[111574]: WARNING: registrar [sip_msg.c:194]: check_contacts(): contact uri is too long: [sip:username@host:port;app-id=929724111839;pn-type=firebase;pn-tok=dYqC3AnzCxI:APA91bF84yDlViEZtJyuUd-9icZYAxsn0f8AAsV97kYzBiSo1uu1VRcI6IWsUQP8evlYCltEHJpjKf9alnyIxcRiRaVDugu4CF7ZgaI3vVw2Ls22mW6K7TGJJ90iTs7g-G1sE5oVTdC1;pn-silent=1;transport=tls]
I haven't checked yet, what RFC 3261 says about length of contact uri (if anything).
Comments?
-- Juha
It turned out that registrar module takes max contact size from contact_max_size param that defaults to 255.
Would it make sense to increase the default (and location table contact column size) for the next K release so that K would work out-of-the-box with e.g. Linphone?
-- Juha
Looks like also the SIP world is getting more complex all the time and URIs are getting larger.
How about if I increase size of location table contact column from 255 to 386 and make the same change in registrar module contact_max_size param default value?
I checked and didn't find any other code that would be affected by the change.
-- Juha
Hello,
if such change to increase the default is to be done, I think it is better to double it, rather that just adding 128 which can be hit soon again.
I haven't checked, but probably the db table column type needs to be changed, iirc, varchar was up to 256 for mysql, but maybe later that limit was lifted.
Cheers, Daniel
On 14.09.17 10:36, Juha Heinanen wrote:
Looks like also the SIP world is getting more complex all the time and URIs are getting larger.
How about if I increase size of location table contact column from 255 to 386 and make the same change in registrar module contact_max_size param default value?
I checked and didn't find any other code that would be affected by the change.
-- Juha
Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Daniel-Constantin Mierla writes:
if such change to increase the default is to be done, I think it is better to double it, rather that just adding 128 which can be hit soon again.
OK.
I haven't checked, but probably the db table column type needs to be changed, iirc, varchar was up to 256 for mysql, but maybe later that limit was lifted.
Size of contact column in location.xml is &hf_len. Better to replace with a constant.
-- Juha
On 14.09.17 12:06, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
if such change to increase the default is to be done, I think it is better to double it, rather that just adding 128 which can be hit soon again.
OK.
I haven't checked, but probably the db table column type needs to be changed, iirc, varchar was up to 256 for mysql, but maybe later that limit was lifted.
Size of contact column in location.xml is &hf_len. Better to replace with a constant.
The values are defined inside entities.xml in the same folder. I would put there contact_len as a new entity defined for 512, because I think we need to adjust also for other modules that store contact URI, such as presence or dialog, because they will be hit by same issue.
Cheers, Daniel
Daniel-Constantin Mierla writes:
The values are defined inside entities.xml in the same folder. I would put there contact_len as a new entity defined for 512, because I think we need to adjust also for other modules that store contact URI, such as presence or dialog, because they will be hit by same issue.
Perhaps not, since when gruu is used (like is the case here), Contact URI does not contain so much stuff in non-REGISTER requests/replies.
-- Juha
-
Daniel-Constantin Mierla -
Juha Heinanen