- Modify parsing of a database URL so that a '/' character is accepted as a valid character in the password part of the URL.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> This change modifies the parsing of the DB URL so that '/' characters can be included in the password field. The modified algorithm is similar to that used when a '@' character is contained in the password. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4017
-- Commit Summary --
* lib/srdb1: Allow '/' in database URL passwords
-- File Changes --
M src/lib/srdb1/db_id.c (35)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4017.patch https://github.com/kamailio/kamailio/pull/4017.diff
As per RFC1738 > The user name (and password), if present, are followed by a >commercial at-sign "@". Within the user and password field, any ":", >"@", or "/" must be encoded.
[1] https://datatracker.ietf.org/doc/html/rfc1738#section-3.1
Yes, but the existing code for the DB URL does not follow this RFC. It allows both ':' and '@' without encoding. Also, the value is not decoded when the password is sent to the database engine, so encoding characters in the password is not possible without significantly rewriting the existing code. It therefore seems reasonable to make a simple change to add support for '/'. Note also that the DB URL is not used in SIP messaging but is just a mechanism that Kamailio has implemented for accessing databases.
I agree that the DB URL is more a Kamailio specific topic and don't follow the common URL standard as linked in the previous comment. Lets give it a bit more time for review and then merge it, if nobody else objects.
Thanks, merging it.
Merged #4017 into master.