[kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

List overview All Threads
Download

newer

older

git:master:ff695de3: core: kemi -...

git:master:a0859762: etc:...

Holger Freyther

28 Oct 2016 28 Oct '16

2:42 p.m.

This can be used with sipcapture and begings with M2UA and ISUP support. More SIGTRAN (M3UA, SUA) support is planned and maybe TCAP/MAP in the future.

The ISUP message format depends on the specific message so I have exported a Smalltalk ITU ISUP model to C to avoid manual errors. You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/837

-- Commit Summary --

* ss7: Introduce the beginning of a ss7 module

-- File Changes --

A modules/ss7/Makefile (19) A modules/ss7/README (57) A modules/ss7/isup_generated.c (467) A modules/ss7/isup_generated.h (130) A modules/ss7/isup_parsed.c (485) A modules/ss7/isup_parsed.h (37) A modules/ss7/ss7.c (348)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/837.patch https://github.com/kamailio/kamailio/pull/837.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837

Attachments:

attachment.html (text/html — 3.6 KB)

Show replies by date

Alexandr Dubovikov

28 Oct 28 Oct

2:48 p.m.

should we keep this module's name or change to another ?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256940321

Holger Freyther

2:48 p.m.

sipcapture is using the HEPv3 protocol and it can encapsulate non SIP payloads (e.g. M2UA+MTP+ISUP). This is a first implementation/try and only supports M2UA/ITU MTP/ITU ISUP. ISUP is converted from the wire message to a semi-parsed (some fields are extracted but not all) JSON object and then converted to a string. A parameter exists to get the string representation from C into the kamailio script.

@adubovikov

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256940410

Alexandr Dubovikov

2:48 p.m.

@miconda any suggestion ?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256940541

Daniel-Constantin Mierla

3:02 p.m.

Trying to understand what's the module about in order to be able to make more comments on its name:

* does it receive ss7 packet over hep3 or it can forward it to homer over hep3? In Kamailio we can also receive binary packets which are not sip (we do for stun module) * what is the target in long term for the module? In other words, what it tries to achieve from the point of view of sip and ss7 worlds? E.g., routing ss7 or just analyzing them?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256944705

Holger Freyther

3:08 p.m.

* It receives M2UA over hep3 (through the sipcapture module) * Right now it is just meant to parse ISUP (and later TCAP/MAP) and store it in the home/sipcapture db.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256946295

Alexandr Dubovikov

3:08 p.m.

The module will be able to parse ISUP binary protocol to string serialization i.e. JSON or pseudo variables and later we can insert the parsed messages into DB and using it in Homer.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256946418

Daniel-Constantin Mierla

3:16 p.m.

Then maybe ss7ops is more appropriate as name, not to suggest a protocol support.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256948334

Holger Freyther

6:33 p.m.

Will rename and right now wait for more feedback.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256995175

Daniel-Constantin Mierla

31 Oct 31 Oct

8:04 p.m.

Some remarks:

* there are several places where I spotted 'sipcapture' as module name * each .c and .h file must have at a top the license text and copyright line * the documentation has to be written in xml docbook format, stored inside the doc/ subfolder of the module directory (like the other modules)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-257404532

Holger Freyther

11 Nov 11 Nov

6:54 p.m.

* Did the rename locally * Will write docbook * For license text/copyright. The ISUP table is generated and I don't think it can be copyrighted (the information is to match ITU ISUP, no creative process involved). What license text should be there?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260028298

Daniel-Constantin Mierla

8:12 p.m.

Ohh, I missed the fact those file were generated -- it is ok to leave them without a copyright header if the generator doesn't insert one.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260045282

Holger Freyther

9:16 p.m.

Okay, renamed directory and module name to ss7ops, instead of handwriting the README (I wondered why one would do that) added a minimal docbook (based on the sipcapture one).

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260057421

Olle E. Johansson

12 Nov 12 Nov

8:57 a.m.

Seems like "ss7capture" would be a better name if I understand this correctly. I would like to use the name to relate it to sipcapture.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260110487

Alexandr Dubovikov

9 a.m.

disagree, because we can use the module not only for "capturing scenarios", but hypothetically also for interworking and/or SIP-I/SIP-T.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260110606

Olle E. Johansson

9:01 a.m.

Ok, I see. Then I'm ok with the name :-)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260110625

Alexandr Dubovikov

9:02 a.m.

don't forget also about IMS and MAP/TAP, CAMEL... this is also a huge area for ISUP

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260110658

Olle E. Johansson

9:02 a.m.

Then we need to clarify the relationship to the existing SIPT module.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260110668

Alexandr Dubovikov

9:04 a.m.

unfortunately existing SIP-I module has very limited functionality and couldn't be use here.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260110728

Olle E. Johansson

9:06 a.m.

In my opinion that's fine as long as we know that these are not built to work together. We have multiple modules overlapping since before.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260110804

Daniel-Constantin Mierla

10:49 a.m.

Merged #837.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#event-856722043

Daniel-Constantin Mierla

10:49 a.m.

Thanks for the new module, merged!

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260115004

Daniel-Constantin Mierla

11:06 a.m.

@zecke - I got some warnings when compiling the module, so I pushed some fixes. Check the commit e0d26f780ed551bd993ca36ac125e87a16db7709 - it seemed wrong initialization of the same index, I guessed it should be the next, but it might not be the right.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260115717

Daniel-Constantin Mierla

11:08 a.m.

@zecke - can you also add basic examples of using the params and functions in the docbook xml. You can see in other modules, like:

* https://github.com/kamailio/kamailio/blob/master/modules/async/doc/async_adm...

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260115780

Holger Freyther

13 Nov 13 Nov

11:53 p.m.

Thank you. 53 is indeed the right value for the UPA message.I will look into more/better documentation.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-260222908

3020

Age (days ago)

3036

Last active (days ago)

sr-dev@lists.kamailio.org

24 comments

4 participants

tags (0)

participants (4)

Alexandr Dubovikov
Daniel-Constantin Mierla
Holger Freyther
Olle E. Johansson