You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/462
-- Commit Summary --
* debugger: fifo module level/facility setters * debugger: fifo module level/facility getters * debugger: update doku for fifo commands * debugger: destroy debugger shm hashtable
-- File Changes --
M dprint.c (16) M dprint.h (2) M modules/debugger/Makefile (1) M modules/debugger/debugger_api.c (58) M modules/debugger/debugger_api.h (1) M modules/debugger/debugger_mod.c (272) M modules/debugger/doc/debugger_admin.xml (77)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/462.patch https://github.com/kamailio/kamailio/pull/462.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/462
We try to obsolete the MI interface and use only the RPC interface. While not a stric policy not to add a new MI command, but there must be an equivalent RPC command for it, so when MI is going to be disabled, then RPC has all the correspondent commands. So you have to add the rpc commands (can be separate pull request).
Also, I noticed that two commits have the same message, but one is to the core, exposing the function to get the syslog facility.
Otherwise I am fine with the pull request.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/462#issuecomment-168967330
Added separate commit for core facility2str(). Added rpc level/facility setters/getter.
While testing this I've found issue #463 which was happening also before this pull request when issuing "kamcmd dbg.mod_level core 1" if the module level wasn't configured in cfg file: ```modparam("debugger", "mod_level", "core=3")```
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/462#issuecomment-169313047
Thanks, you can merge it.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/462#issuecomment-169327619
Merged #462.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/462#event-507080477
-
Daniel-Constantin Mierla -
Stefan Mititelu