Added Call-ID mask Support for Topos with API call from Topoh to mask the callID Call-ID mask happens before the request is sent downstream and unmasked when received from downstream.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3347
-- Commit Summary --
* Topos: Added Call ID mask when sending to Downstream * Topos: Added CallID Mask Document for Topos
-- File Changes --
M src/modules/topos/doc/topos_admin.xml (20) M src/modules/topos/topos_mod.c (119) M src/modules/topos/tps_msg.c (37) M src/modules/topos/tps_msg.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3347.patch https://github.com/kamailio/kamailio/pull/3347.diff
The lump operations do not change the Call-Id immediately, I have to think about what could be a good solution, eventually applying changes as an intermediary step or do a custom in-place replacement of Call-Id.
The lump operations do not change the Call-Id immediately, I have to think about what could be a good solution, eventually applying changes as an intermediary step or do a custom in-place replacement of Call-Id.
Thankyou, However The same methord of lump operation is ued in Topoh and this code was working in our VoIP network when locally tested.
Topoh does not use call-id value for finding records, like it is done by topos. I will have to go deeper in the code to review properly and be sure it works as expected. There are some tricks that a partial change can be discovered, but I am not sure that it applies to call-id.
Topoh does not use call-id value for finding records, like it is done by topos. I will have to go deeper in the code to review properly and be sure it works as expected. There are some tricks that a partial change can be discovered, but I am not sure that it applies to call-id.
when lump is removed from the momory i am getting error in releasing the memory as below. Is the allocation and release of memory release of memory for the leg is related to call-ID. If the Call-ID mask is removed this error is not available. The error is as below:
9(3259925) CRITICAL: {1 20 INVITE 1307026397@xx.xxx.xx.xx} <core> [core/mem/q_malloc.c:501]: qm_free(): BUG: bad pointer 0x7faec4a78500 (out of memory block!) called from core: core/data_lump.c: free_lump(470) - ignoring
Merged #3347 into master.
I merged it, going to update some parts. Thanks!