You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3375
-- Commit Summary --
* acc: typo * acc_json: typos * acc_radius: typo * alias_db: typo * app_java: typos * app_jsdt: typos * app_lua: typos * app_lua_sr: typos * app_mono: typos * app_perl: typos * app_python: typo * app_ruby: typos * app_sqlang: typos * async: typos * auth: typos * auth_db: typos * auth_diameter: typos * auth_ephemeral: typos * auth_identiy: typos * auth_radius: typos * avpops: typos
-- File Changes --
M src/modules/acc/doc/acc_admin.xml (2) M src/modules/acc_json/acc_json_mod.c (2) M src/modules/acc_json/doc/acc_json_admin.xml (2) M src/modules/acc_radius/doc/acc_radius_admin.xml (2) M src/modules/alias_db/doc/alias_db_admin.xml (2) M src/modules/app_java/README-draft (12) M src/modules/app_java/doc/app_java_admin.xml (4) M src/modules/app_java/kamailio_java_folder/java-untested/siprouter_src/SipMsg.java (2) M src/modules/app_java/kamailio_java_folder/java/siprouter_src/SipMsg.java (2) M src/modules/app_jsdt/app_jsdt_mod.c (8) M src/modules/app_jsdt/doc/app_jsdt_admin.xml (4) M src/modules/app_jsdt/duktape.c (10) M src/modules/app_lua/app_lua_mod.c (10) M src/modules/app_lua/doc/app_lua_admin.xml (2) M src/modules/app_lua_sr/doc/app_lua_sr_admin.xml (4) M src/modules/app_mono/app_mono_mod.c (4) M src/modules/app_perl/app_perl_mod.c (2) M src/modules/app_perl/doc/app_perl_admin.xml (4) M src/modules/app_perl/doc/app_perl_pod.xml (2) M src/modules/app_perl/doc/app_perl_samples.xml (2) M src/modules/app_perl/lib/perl/Kamailio/LDAPUtils/LDAPConf.pm (4) M src/modules/app_python/doc/app_python_admin.xml (2) M src/modules/app_ruby/app_ruby_mod.c (2) M src/modules/app_ruby/doc/app_ruby_admin.xml (2) M src/modules/app_sqlang/app_sqlang_mod.c (8) M src/modules/app_sqlang/doc/app_sqlang_admin.xml (2) M src/modules/app_sqlang/squirrel/sqstdlib/sqstdrex.cpp (2) M src/modules/app_sqlang/squirrel/squirrel/sqvm.cpp (6) M src/modules/async/doc/async_admin.xml (4) M src/modules/auth/auth.xml (18) M src/modules/auth/doc/auth_functions.xml (2) M src/modules/auth/doc/auth_params.xml (14) M src/modules/auth/nc.c (6) M src/modules/auth/nid.h (4) M src/modules/auth/ot_nonce.c (6) M src/modules/auth_db/authorize.c (2) M src/modules/auth_db/doc/auth_db_admin.xml (4) M src/modules/auth_diameter/authorize.c (2) M src/modules/auth_diameter/authorize.h (2) M src/modules/auth_diameter/avp.c (2) M src/modules/auth_diameter/defs.h (2) M src/modules/auth_diameter/message.c (2) M src/modules/auth_diameter/tcp_comm.c (2) M src/modules/auth_ephemeral/auth_ephemeral_mod.c (2) M src/modules/auth_ephemeral/doc/auth_ephemeral_admin.xml (2) M src/modules/auth_identity/auth_hdrs.c (2) M src/modules/auth_identity/auth_identity.c (10) M src/modules/auth_identity/auth_tables.c (10) M src/modules/auth_identity/doc/auth_identity_functions.xml (2) M src/modules/auth_radius/doc/auth_radius_admin.xml (2) M src/modules/auth_radius/sterman.c (2) M src/modules/avpops/avpops.c (4) M src/modules/avpops/doc/avpops_admin.xml (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3375.patch https://github.com/kamailio/kamailio/pull/3375.diff
Are you expecting to be many more pull requests related to typos?
We should wait and collect all in one PR and squeeze per module, otherwise there are more and more chances of conflicts when we need to backport fixes to the code.
The changes here are for modules, whose name starts with “a”. I do not expect more typos in modules, whose name starts with “a”.
What I mean is in the global context of your planned work to fix the typos, which is very appreciated, but has to be coordinated and planned somehow, because the commit messages are not very explicit and repeat, then backports can be affected, making the release procedure more difficulat.
For example, the acc module got several PRs lately related to typos:
``` 901d9cac2f 2023-02-04 15:28:48 +0200 Дилян Палаузов acc: typos 06ffb667b7 2022-12-24 16:38:35 +0200 Дилян Палаузов acc: typo fuNction 55c77f0966 2022-12-12 19:27:44 +0200 Дилян Палаузов acc: typos a/an ```
This PR has another commit to `acc` module. There are other types of typos, but then we need to understand how your work is planned and how can impact the development of the code. It is really nice to have good spelling, but if the writing/maintenance of the C code becomes to complex, we need to coordinate better.
Maybe we just keep this PR open until you consider all the spell checking work finished completely, then rebase and merge.
Of course, others can comment or suggest alternative to deal with it.
Good to bring this up, it might be indeed cause some issues for backports. We might consider not backporting this spelling fixes to the stable branches, just fixes for "real" bugs. I think we got some hundreds of these commits in the last weeks, which is impressive, but quite some work to backport.
Problems can also be when backporting fixes, because if a line was changed for a spell fix in variable/function name or in the comment and the code fix changes the same line or adjacent lines, then backporting fails because it does not matches the context in the file.
So sometimes backporting typos can help, but if it is a continuous work that results in hundred of commits it becomes a big overhead to track everything, what was in old or new code, what was backported or not, etc ...
I have changes on my computer concerning typos, and I submit them in batches for some modules. I have also changes which change typos and documentation, these I will submit in separate PR per modules, once I am confident with the changes.
The changes were **caught** by using regex and whatsoever. At this place I wanted to write that I plan no further changes, but while writing the previous sentence I looked for **catched** and replaced it locally with **caught**.
Since the typos were not backported so far I assume that there is no practice of backporting typos. The concerns raised by having several commits with the identical title, in the context of backporting typos, are not traceable by me. When it comes to the amount of PRs, this information is not part of the git history, so my understanding is that it is irrelevant if fixes in three modules will be spread in one, two or three PRs.
I do not plan more changes, than I have currently. But if I find something while reading the manuals, I might or might not submit rewording.
I have also changes which change typos and documentation,
which change/add/remove sentences in the documentation
Merged #3375 into master.
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Дилян Палаузов