<!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> Fix the following issues found by Coverity: 3c86d68 fixes defect [85605](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 7f603ec fixes defect [86015](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 2772f09 fixes defects [85807](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… and [85651](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… d8fdcb3 fixes defects [153773](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId…=153773), [85749](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… and [85702](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 3a9365f fixes defects [85541](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… and [85543](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… dbafb5a fixes defect [85484](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 535eb88 fixes defect [155203](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId… You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1199 -- Commit Summary -- * carrierroute: avoid out-of-bounds access when resetting opts * carrierroute: check pointer before dereferencing it * carrieroute: remove logically dead code * carrierroute: avoid comparing size_t types with negative values * carrierroute: check return value for fseek * carrierroute: avoid truncating value returned by fgetc * carrierroute: avoid ovverruning a fixed sized buffer -- File Changes -- M src/modules/carrierroute/cr_config.c (125) M src/modules/carrierroute/cr_db.c (6) M src/modules/carrierroute/cr_fifo.c (11) M src/modules/carrierroute/cr_func.c (14) M src/modules/carrierroute/parser_carrierroute.c (13) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1199.patch https://github.com/kamailio/kamailio/pull/1199.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1199