Begin forwarded message:
From: Olle E. Johansson <oej(a)edvina.net <mailto:oej@edvina.net>>
Subject: [sr-dev] git:master:5c90e6e2 <git:master:5c90e6e2>: DMQ:
dmq_notification_address_list is initialized to NULL
Date: 21 December 2022 at 15:27:49 CET
To: sr-dev(a)lists.kamailio.org <mailto:sr-dev@lists.kamailio.org>
Reply-To: "Kamailio (SER) - Development Mailing List"
<sr-dev(a)lists.kamailio.org <mailto:sr-dev@lists.kamailio.org>>
Module: kamailio
Branch: master
Commit: 5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb
URL:
https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
<https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb>
Author: Olle E. Johansson <oej(a)edvina.net <mailto:oej@edvina.net>>
Committer: Olle E. Johansson <oej(a)edvina.net <mailto:oej@edvina.net>>
Date: 2022-12-21T15:27:28+01:00
DMQ: dmq_notification_address_list is initialized to NULL
This code led to random and unpredictable behaviour when loading a configuration with
multiple notification nodes.
---
Modified: src/modules/dmq/dmq.c
---
Diff:
https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
<https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb.diff>
Patch:
https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
<https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb.patch>
---
diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c
index 843b7e3e4d2..f4a66c3d847 100644
--- a/src/modules/dmq/dmq.c
+++ b/src/modules/dmq/dmq.c
@@ -379,7 +379,7 @@ static int dmq_add_notification_address(modparam_t type, void * val)
}
/* initial allocation */
- if (dmq_notification_address_list == 0) {
+ if (dmq_notification_address_list == NULL) {
dmq_notification_address_list = pkg_malloc(sizeof(str_list_t));
if (dmq_notification_address_list == NULL) {
PKG_MEM_ERROR;
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-leave(a)lists.kamailio.org
<mailto:sr-dev-leave@lists.kamailio.org>