#### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description @henning @miconda this is a draft for the 5.7 stable branch which disables threading for process_no > 0. This restricts thread wrappers to the parent process.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3744
-- Commit Summary --
* [DRAFT]: restrict thread execution to process_no = 0
-- File Changes --
M src/core/rthreads.h (18)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3744.patch https://github.com/kamailio/kamailio/pull/3744.diff
no idea what this is?
Henning
On Tue 6. Feb 2024 at 12:34, space88man ***@***.***> wrote:
Pre-Submission Checklist
- Commit message has the format required by CONTRIBUTING guide
- Commits are split per component (core, individual modules, libs,
utils, ...)
- Each component has a single commit (if not, squash them into one
commit)
- No commits to README files for modules (changes must be done to
docbook files in doc/ subfolder, the README file is autogenerated)
Type Of Change
- Small bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds new functionality)
- Breaking change (fix or feature that would change existing
functionality)
Checklist:
- PR should be backported to stable branches
- Tested changes locally
- Related to issue #XXXX (replace XXXX with an open issue number)
Description
@henning https://github.com/henning @miconda https://github.com/miconda this is a draft for the 5.7 stable branch which disables threading for process_no > 0. This restricts thread wrappers to the parent process.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3744 Commit Summary
- cd4960b
https://github.com/kamailio/kamailio/pull/3744/commits/cd4960bb5b4ee64cb5c7b0e378af3f53287e255b [DRAFT]: restrict thread execution to process_no = 0
File Changes
(1 file https://github.com/kamailio/kamailio/pull/3744/files)
- *M* src/core/rthreads.h
Patch Links:
- https://github.com/kamailio/kamailio/pull/3744.patch
- https://github.com/kamailio/kamailio/pull/3744.diff
— Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/3744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJ2UDEVNB4MKMH22PVBN3YSIINZAVCNFSM6AAAAABC32BDCWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZDANJWGU4TKOA . You are receiving this because you were mentioned.Message ID: ***@***.***>
no idea what this is? Henning
This is related to your comment on the 5,7 stable branch: this PR restricts thread wrapping to process_no=0, i.e., from workers POV - no change in behaviour so the same as 5.7.4, 5.7.3 ...
For process_no=0 it will run libssl calls in a thread to prevent thread locals from being created pre-fork.
@space88man: regarding the above comment, you tagged the wrong Henning in the PR description, the one involved in Kamailio development is @henningw.
The patch in PR seems ok, just wait a bit till merging just in case someone else wants to take a look.
Ah so sorry about that : I have a new DRAFT PR for master that implements
enable_tls_threads = 0|1|2
that disables threading when not essential https://github.com/kamailio/kamailio/pull/3745
On Tue, 6 Feb 2024 at 21:21, Daniel-Constantin Mierla via sr-dev < sr-dev@lists.kamailio.org> wrote:
@space88man https://github.com/space88man: regarding the above comment, you tagged the wrong Henning in the PR description, the one involved in Kamailio development is @henningw https://github.com/henningw.
The patch in PR seems ok, just wait a bit till merging just in case someone else wants to take a look.
— Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/3744#issuecomment-1929553161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABO7UZOEM2PXNQEHG2NRHA3YSIUMFAVCNFSM6AAAAABC32BDCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGU2TGMJWGE . You are receiving this because you are subscribed to this thread.Message ID: kamailio/kamailio/pull/3744/c1929553161@github.com _______________________________________________ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-leave@lists.kamailio.org
@henning - so sorry tagged the wrong name.
@space88man pushed 1 commit.
7ec9046fa9dd1ac1dc38bde94e66b6b47fca4839 [DRAFT] restrict thread execution to process_no = 0
@space88man pushed 1 commit.
81b61e7bb344aca52da81dfee82d8e40a7cebaca [DRAFT] restrict thread execution to process_no = 0
@space88man pushed 4 commits.
0d0c9910095e3e87a4d27be5af30f02cd5f26020 core/rthreads.h: thread wrapper for db_XXXX_query 0936b6b70efe2e9d05766ce925ca10e4ff4bf7be db_postgres: libssl thread guard for db_postgres_close 5808226593fcf11d4713b2161809466568c51682 db_unixodbc: libssl thread guards for db_unixodbc_(close|free_result|query) f4edfd47aa18aecaf5650bb39a69c6e800c14f2d db_mysql: libssl thread guard for db_mysql_close
Merged #3744 into 5.7.
-
Daniel-Constantin Mierla -
Henning Sprang
-
Richard Chan -
space88man