#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description core: make get_hdr_by_name/next_sibling_hdr_by_name case insensitive
- Credits goes to Alexandr Dubovikov You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1217
-- Commit Summary --
* caseinsensitive get_hdr_by_name/next_sibling_hdr_by_name
-- File Changes --
M src/core/parser/msg_parser.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1217.patch https://github.com/kamailio/kamailio/pull/1217.diff
The commit message doesn't have the format required by the contributing guide, although you have checked that box. Amend the commit message accordingly:
* https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
Closed #1217.
Reopened #1217.
Sorry what's wrong? Looks like formatted right. Or should I elaborate in desc why this fix is required?
See the commit message as it appears in the patch:
* https://github.com/kamailio/kamailio/commit/b84d4a1f09b6310522ac83546a7a34b2...
What you had as Description in PR comment is not in the commit message.
I see thanks. I thought Description was commit message :( So I must make new commit from scratch, right?
The commit message is the one you give when doing "git commit ...".
The patch is small, so probably is faster to use the diff (https://github.com/kamailio/kamailio/commit/b84d4a1f09b6310522ac83546a7a34b2...), make a fresh clone of kamailio repo and do the commit again, with a new PR.
Otherwise, you can search on the web how to amend a commit message, but can take some time to sort out when the commit was pushed remote.
Pushed patch with a manual commit.
Closed #1217.