This fixes force socket in that it will always be forced and not only when there is no socket. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/847
-- Commit Summary --
* nathelper: force socket if set
-- File Changes --
M modules/nathelper/nathelper.c (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/847.patch https://github.com/kamailio/kamailio/pull/847.diff
Thanks!
I will merge, I think it is how force_socket was meant, so I will merge if nobody has complains.
On the other hand, having the option to say to use force_socket when not set, could be useful. I let that as an enhancement.
I agree that it would be useful. Maybe as a default socket? Then again, the module already has a fallback mechanism if it is not set based on the dest uri.
I'm also planning on enhancing this modparam as in my testing (and looking at strace) it only works when I enter an IP address without port.
Merged #847.
-
Daniel-Constantin Mierla -
Timmo Verlaan