<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2409
-- Commit Summary --
* Added compression for rtpengine
-- File Changes --
M src/modules/rtpengine/Makefile (2) A src/modules/rtpengine/compress.c (71) A src/modules/rtpengine/compress.h (27) M src/modules/rtpengine/config.c (3) M src/modules/rtpengine/config.h (1) M src/modules/rtpengine/rtpengine.c (64)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2409.patch https://github.com/kamailio/kamailio/pull/2409.diff
@pchero pushed 1 commit.
cfd8ee362bf5bef9fee20092c8a2ee479f5fba3c Removed comments
@pchero pushed 2 commits.
ced1724da46dad7007fa50618284f8ddec8a839a Fixed indentation 9a2493a21ea6682bf725aeb5cd519fc724c193e2 Fixed indentation
Can you provide more details about the scope of this patch? Also, you have ti add documentation to the xml file in the doc/ subfolder for the new modparam related to compress size.
@pchero pushed 3 commits.
b39762a65537ac564f3aaaeaa3915cac24b24f2d Merge branch 'Add_compression' of https://github.com/pchero/kamailio into Add_compression cc4cbee132b029250b675cec6eee51b926e0ad6a rtpengine: added udp message compression 56e8d93b072cd7857c098e95c85f79f2af08b0d3 rtpengine: added udp message compression
@pchero pushed 1 commit.
7b66abc95d38369e4695afe61db4cf4778ea772f rtpengine: added the message compression
Hi @miconda , thank you for your review. I've fixed my MR as you commented. Could you please take a look again?
Thank you.
Hi @miconda ,
My new commit makes fails, but I didn't change any codes from the previous one. Could I get some help why this makes fail?
Thank you.
The failure is about LGTM not being able to do the analyzis, so not related to code, but likely it was an issue on LGTM service.
You haven't commented on my question about the scope of this PR, to save bandwidth between kamailio and rtpengine? What version of rtpengine is required?
@rfuchs - any comments from you on this PR?
Sorry, I missed that part.
This patch is affected to the Kamailio's RTPEngine module only, but also need to be fixed from the RTPEngine's side. https://github.com/sipwise/rtpengine/pull/1052
Hi @miconda ,
Thank you for your kind review. But I don't think this change is valid and useful anymore, at this moment. So, I'm closing this MR now.
Thank you for all messages.
Kind regards, Sungtae
Closed #2409.