16 Jan
2014
16 Jan
'14
9:48 p.m.
Module: sip-router
Branch: master
Commit: 6f685460f1d7fd6ff07e55f2a807322168638988
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6f68546…
Author: Ovidiu Sas <osas(a)voipembedded.com>
Committer: Ovidiu Sas <osas(a)voipembedded.com>
Date: Thu Jan 16 14:46:32 2014 -0500
kex: new stats RPC commands
---
modules/kex/core_stats.c | 285 +++++++++++++++++++++++++++++++++++++++++
modules/kex/doc/kex.xml | 14 ++
modules/kex/doc/kex_admin.xml | 50 +++++++
3 files changed, 349 insertions(+), 0 deletions(-)
Diff:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=6f6…
20 Jan
20 Jan
5:17 p.m.
Hi Ovidiu!
Thanks for this commit.
A few questions:
- Did you update the README? THe original commit did not commit a new README file. Maybe
you did it later.
The docs say:
<section id="kex.r.stats.get_statistics">
+ <title>
+ <function
moreinfo="none">stats.get_statistics</function>
+ </title>
+ <para>Print the list of available internal statistics.</para>
+ <para>Parameters: <emphasis>statsid</emphasis> - which
statistics to
+ be printed. If set to 'all' then all statistics are
printed; if
+ set to 'statsgroup:' then all statistics in the group are
printed;
+ if set to 'statsname' then the statistics identified by
the name
+ is printed.</para>
"all statistics" - does this really apply to ALL - user configured and produced
by other modules? Or just the kex module stats?
Maybe a clarification would be good. If it's all, including other modules, there's
an overlap with stats and counters.
/O
5:24 p.m.
I did make in the doc directory to check that everything is allright,
but now I figured out that I need to run make readme to generate the
README.
-ovidiu
On Mon, Jan 20, 2014 at 10:17 AM, Olle E. Johansson <oej(a)edvina.net> wrote:
Hi Ovidiu!
Thanks for this commit.
A few questions:
- Did you update the README? THe original commit did not commit a new README
file. Maybe you did it later.
The docs say:
<section id="kex.r.stats.get_statistics">
+ <title>
+ <function
moreinfo="none">stats.get_statistics</function>
+ </title>
+ <para>Print the list of available internal
statistics.</para>
+ <para>Parameters: <emphasis>statsid</emphasis> - which
statistics to
+ be printed. If set to 'all' then all statistics are
printed; if
+ set to 'statsgroup:' then all statistics in the
group are printed;
+ if set to 'statsname' then the statistics identified
by the name
+ is printed.</para>
"all statistics" - does this really apply to ALL - user configured and
produced by other modules? Or just the kex module stats?
Maybe a clarification would be good. If it's all, including other modules,
there's an overlap with stats and counters.
/O
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
--
VoIP Embedded, Inc.
http://www.voipembedded.com
5:39 p.m.
ALL applies only to stats in the same group (ie stats - no overlap
with other modules).
There are no dependencies between kex and counters and therefor
there's no access (API) between them.
If you fell that this should be added to the README, go ahead an
update the file.
-ovidiu
On Mon, Jan 20, 2014 at 10:17 AM, Olle E. Johansson <oej(a)edvina.net> wrote:
"all statistics" - does this really apply to
ALL - user configured and
produced by other modules? Or just the kex module stats?
Maybe a clarification would be good. If it's all, including other modules,
there's an overlap with stats and counters.
/O
19 May
19 May
12:05 p.m.
Ovidiu,
i gave your stats rpc commands a try using xmlrpc, and noticed that the
result is not correctly formatted:
Received the following response:
HTTP/1.0 200 OK
Via: SIP/2.0/TCP 127.0.0.1:34153
Server: OpenXg SIP Proxy (4.2.0-0 (x86_64/linux))
Content-Length: 547
<?xml version="1.0"?>
<methodResponse>
<params>
<param>
<value><string>core:bad_URIs_rcvd = 27</string>
<string>core:bad_msg_hdr = 0</string>
<string>core:drop_replies = 0</string>
<string>core:drop_requests = 0</string>
<string>core:err_replies = 0</string>
<string>core:err_requests = 0</string>
<string>core:fwd_replies = 0</string>
<string>core:fwd_requests = 3</string>
<string>core:rcv_replies = 63</string>
<string>core:rcv_requests = 522</string>
<string>core:unsupported_methods = 37</string>
</value>
</param>
</params>
</methodResponse>
the value should be array.
i remember that these kind of problems have been fixed before, but don't
remember the details.
-- juha
3842
days inactive
3965
days old
5 comments
3 participants
participants (3)
-
Juha Heinanen -
Olle E. Johansson -
Ovidiu Sas