as per http://kamailio.org/docs/modules/3.3.x/modules_k/dialog.html#idp148408 a db_fetch_row of 0 should not load data from the DB At all.
I think doing this in mod_init makes the most sense, rather than further down in select_entire_dialog_table or similar. The docs say setting to 0 will only restrict the initial load on startup, not any subsequent loads. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/295
-- Commit Summary --
* Fix dialog module to not load DB when db_fetch_rows == 0
-- File Changes --
M modules/dialog/dialog.c (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/295.patch https://github.com/kamailio/kamailio/pull/295.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/295
It is not easy to track all those patches one after the other and because the commit message is not formatted as we recommend, I would suggest:
* make a diff between your branch and kamailio main master branch * apply it to a fresh clone of kamailio main master branch * write the commit message as per guidelines at: http://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message * make a new pull request -- which will be easier to review
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/295#issuecomment-134267849
Closed #295.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/295#event-391626223
-
Daniel-Constantin Mierla -
jaybinks