#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #2946
#### Description migrate modules to pcre2
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3535
-- Commit Summary --
* regex: migration to pcre2
-- File Changes --
M src/modules/regex/Makefile (11) M src/modules/regex/regex_mod.c (121)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3535.patch https://github.com/kamailio/kamailio/pull/3535.diff
I have checkd `pcre2-config` config presence in the CentOS dists. Looks like utility present in the CentOS 7, 8, 9 but does not exist.
Should you we drop CentOS 6 support?
CentOS dropped CentOS 6 support years ago.
Anyone running Kamailio on CentOS 6 is most likely not updating their Kamailio either. If you pay Redhat for extended support, you've got another year of RHEL6. Those users can run a mildly older branch of Kamailio until that day comes. Kamailio 5.7.x
I am saying this as someone this would affect. Drop us.
@linuxmaniac pushed 2 commits.
b78a661cdadf2992b610ab8e62a3208431226feb pkg/kamailio/deb: migrate to pcre2 f53de5c16a9b570a13f8fb163a651b61ab07be7f regex: migration to pcre2
@miconda should I try to keep pcre3 and pcre2 at the same time or just drop cpre3? Is is worth the effort?
Fine for me to drop it and go now for the simpler way. If later proves to be high demand for the old variant, we can find solutions at that time.
@linuxmaniac pushed 2 commits.
497a244458983155c32822bb30a781118c4af8cc pkg/kamailio/deb: migrate to pcre2 78a2669a69e85c80bb1e1f982aedccc62eb19a58 regex: migration to pcre2
@linuxmaniac pushed 2 commits.
52196f955d9b023d1d1340fadd44dcd09a0e6e67 pkg/kamailio/deb: add pcre2 3919987c94f8a334c0279281ff766b6fc54d5964 regex: migration to pcre2
Any regex user willing to check this? It seems to work
I don't think there are many users of this particular module. I would merge it and then see if later are reports about it.
Merged #3535 into master.
-
Daniel-Constantin Mierla -
sergey-safarov
-
SirDMZ
-
Victor Seva