rtpengine: IPv6 address in square brackets interpreted as FQDN.
- After loading from DB rn_address is in form: [x:x:x:x:x:x:x:x]:nnnn, getaddrinfo function expect ipv6 in node argument without square brackets, otherwise, the argument is interpreted as FQDN.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2685
-- Commit Summary --
* rtpengine: remove square brackets from IPv6 address for getaddrinfo function
-- File Changes --
M src/modules/rtpengine/rtpengine.c (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2685.patch https://github.com/kamailio/kamailio/pull/2685.diff
@Den4t: have you checked that setting 0 in place of `]` is not having other side effects? I didn't notice any restore.
@rfuchs: any opinion on this patch?
@miconda
have you checked that setting 0 in place of ] is not having other side effects? I didn't notice any restore.
Yes, hp - is a pointer to pkg_malloc-ed hostname variable, this var is freed right after getaddrinfo and not used any more. I tested this patch localy, work as expected.
@Den4t: have you checked that setting 0 in place of `]` is not having other side effects? I didn't notice any restore.
@rfuchs: any opinion on this patch?
Looks good to me
Thanks, merging it!
Merged #2685 into master.