the transport tag was the only string which used urlencoding for ';' and '=' see line 90 for example
this has lead (on the wire) to headers like: Path: sip:inbound_webrtc@10.3.66.231;lr;received=sip:127.0.0.1:41988%3Btransport%3Dws;ob
to me this does not look like intention?! You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/765
-- Commit Summary --
* dont use url encoding for transport tag in path header
-- File Changes --
M modules/path/path.c (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/765.patch https://github.com/kamailio/kamailio/pull/765.diff
If the = and ; are not encoded, then the transport will be a parameter of the Path URI, not long seen as part of the value of the received parameter.
Were you having troubles with this? Because the module is rather old and used by many, I would expect this would have popped up as an issue if something was broken.
thank you daniel! i am trying to build an edge proxy for a websocket client without using nathelper and till now i dont get the whole picture of how the edge proxy determines the correct outgoing connection to the client for invite and notifies from the backend...
but that doesnt belong here ;) so the pull request is obviously wrong! thank you for your fast clarification!
Closed #765.
One thing to keep in mind for the future: prefix the commit message with the module name, as suggested in contribution guidelines:
* https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
If the pull request is good, then it can be merged directly, otherwise the commit message needs to be adjusted.
You can come on sr-users mailing list with the description of what you want to do or what you don't understand properly and we will try to help.
-
Daniel-Constantin Mierla -
Sebastian Denz