<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
Add CRC32 selection algo. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2558
-- Commit Summary --
* rtpengine: add CRC32 hash algo
-- File Changes --
M src/modules/rtpengine/doc/rtpengine_admin.xml (5) M src/modules/rtpengine/rtpengine.c (4) M src/modules/rtpengine/rtpengine.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2558.patch https://github.com/kamailio/kamailio/pull/2558.diff
Thanks! Looks not intrusive, maybe @rfuchs wants to check it, otherwise can be merged from my point of view.
@rfuchs commented on this pull request.
@@ -2028,14 +2028,17 @@ modparam("rtpengine", "control_cmd_tos", 144)
Default value is 0, legacy algorithm. </para> <para> - The values not falling into the range <quote>0-1</quote> are ignored. + The values not falling into the range <quote>0-2</quote> are ignored.
The meaning of `2` should probably be mentioned in the paragraph just above (line ~2025). Otherwise LGTM.
@smititelu pushed 1 commit.
e62c27f3f5d65543b2aef60d7896d1fe7bb52a27 rtpengine: add CRC32 hash algo
Merged #2558 into master.
Thanks for the merge. I've backported it to 5.3 and 5.4 branches.
@smititelu its a new functionality, and should therefore not backported by default to stable branches, unless it qualifies as a bugfix. Can you provide please more information if this is indeed a bugfix? Otherwise I will revert the commit there.
Like, have the existing algorithm certain problems that are fixed with the new hash algorithm.
Hi @henningw,
We are obtaining smoother rtpengine session distribution results using crc32. Also crc32 is an alternative for those who don't want to load crypto.so module.
So, IMHO, this PR fixes the above two.
Thank you, Stefan
Hello @smititelu, sorry this does not sound like a bug fix to me. With the same argumentation we could e.g. merge the new dispatcher algorithm 13 to stable, as it provides a better call distribution in certain scenarios. :-) I am reverting this commits therefore in stable branches. Please ask next time another developer before backporting some patches.
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Richard Fuchs
-
Stefan Mititelu