<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Following carrierroute module functions are exported to KEMI API.
- cr_load_next_domain ( ) - cr_route ( ) - cr_nofallback_route ( )
Additionally various fix-up free functions added for better memory management. The documentation has been updated to correctly explain various parameters and use cases.
#### Example 1: Proxy Routing ```python3
def route_proxy(self, msg): KSR.info("==================== route_proxy\n") rU = KSR.kx.get_ruser()
if rU == None: return -255
if KSR.carrierroute.cr_route("default", "proxy", rU, rU, "call_id") < 0: KSR.sl.sl_send_reply(400, "Bad Request") return -255
```
#### Example 2: Registrar Routing ```python3
def route_registrar(self, msg): KSR.info("==================== route_registrar\n") rU = KSR.kx.get_ruser()
if rU == None: rU = ""
if KSR.carrierroute.cr_nofallback_route("default", "register", rU, rU, "from_user") < 0: KSR.sl.sl_send_reply(400, "Bad Request") return -255
``` You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3325
-- Commit Summary --
* carrierroute: added fixup free functions * carrierroute: exported cr_load_next_domain(), cr_route() and cr_nofallback_route() to kemi * carrierroute: added helper methods to simplify config and kemi functions, also some code clean up * carrierroute: updated module docs
-- File Changes --
M src/modules/carrierroute/carrierroute.c (46) M src/modules/carrierroute/cr_fixup.c (176) M src/modules/carrierroute/cr_fixup.h (4) M src/modules/carrierroute/cr_func.c (675) M src/modules/carrierroute/cr_func.h (65) M src/modules/carrierroute/doc/carrierroute.xml (79) M src/modules/carrierroute/doc/carrierroute_admin.xml (1403)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3325.patch https://github.com/kamailio/kamailio/pull/3325.diff
For me this looks ok.
I haven't done any deep analysis of the code, not being familiar with the module, but from KEMI export point of view, the approach looks ok. Fine to merge.
Merged #3325 into master.
Thank you for the approval.