Module: sip-router Branch: master Commit: c7adc3cd7610fe1b6479225a0623e0ab9fa3907e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c7adc3cd...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Mon Sep 8 18:49:28 2014 +0200
presence: reduce verbosity for log message printed when sending notify
- info changed with dbg - patch by Luis Azedo luis.azedo@factorlusitano.com
---
modules/presence/notify.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/presence/notify.c b/modules/presence/notify.c index 1d05737..a5184cd 100644 --- a/modules/presence/notify.c +++ b/modules/presence/notify.c @@ -1594,7 +1594,7 @@ jump_over_body: goto error; }
- LM_INFO("NOTIFY %.*s via %.*s on behalf of %.*s for event %.*s\n", + LM_DBG("NOTIFY %.*s via %.*s on behalf of %.*s for event %.*s\n", td->rem_uri.len, td->rem_uri.s, td->hooks.next_hop->len, td->hooks.next_hop->s, td->loc_uri.len, td->loc_uri.s, subs->event->name.len,
Daniel-Constantin Mierla writes:
presence: reduce verbosity for log message printed when sending notify
- info changed with dbg
- patch by Luis Azedo luis.azedo@factorlusitano.com
if i remember correctly, info level was used on purpose, because it was not possible to get the message printed from config file.
if it is not possible to get the message printed from config file, please revert the patch and introduce a module param to change log level.
-- juha
On 08/09/14 22:29, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
presence: reduce verbosity for log message printed when sending notify
- info changed with dbg
- patch by Luis Azedo luis.azedo@factorlusitano.com
if i remember correctly, info level was used on purpose,
ok, good that you caught the change.
because it was not possible to get the message printed from config file.
You want to get access to the SIP message? Isn't it getting to event_route[tm:local-request]?
if it is not possible to get the message printed from config file, please revert the patch and introduce a module param to change log level.
Adding a module parameter seems more suitable, to avoid filling the logs if someone doesn't want those messages.
Cheers, Daniel
Daniel-Constantin Mierla writes:
You want to get access to the SIP message? Isn't it getting to event_route[tm:local-request]?
no, i want to easily see in syslog what messages my proxy is forwarding or generating.
if it is not possible to get the message printed from config file, please revert the patch and introduce a module param to change log level.
Adding a module parameter seems more suitable, to avoid filling the logs if someone doesn't want those messages.
that should be the way to go because the info message has been there for a long time for a purpose. default value of that parameter should be the existing behavior.
-- juha
-
Daniel-Constantin Mierla -
Juha Heinanen