It is about storing in database? Or also mirroring?

Can you try with latest master? I pushed a commit that hopefully fixes it.

On the other hand, the use of flag looks like no longer necessary if tracing mode parameter is set to 't'. Would it be acceptable to just add a new function sip_trace_mode() that will accept one parameter to specify what to track (message, transaction, dialog)? It would be a short form of sip_trace() with 3 parameters, when the two are not needed. I think it would be more coherent for the future to get rid of using also the message flag for tracking the transaction.

Daniel-Constantin Mierla writes: It works now. For me it would be best and simplest if tracing of all request and responses would happen automatically when siptrace module is loaded and suitable parameters are set and when tracing is turned on via an rpc command, i.e., without any function calls in the config.

If that cannot be achived and a function call is needed, one must be enough.

Can you try with latest master? I pushed a commit that hopefully fixes it. On the other hand, the use of flag looks like no longer necessary if tracing mode parameter is set to 't'. Would it be acceptable to just add a new function sip_trace_mode() that will accept one parameter to specify what to track (message, transaction, dialog)? It would be a short form of sip_trace() with 3 parameters, when the two are not needed. I think it would be more coherent for the future to get rid of using also the message flag for tracking the transaction. Cheers, Daniel On 30.09.19 18:00, Juha Heinanen wrote: -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat _______________________________________________ Kamailio (SER) - Development Mailing List sr-dev(a)lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Can you try with latest master? I pushed a commit that hopefully fixes it. On the other hand, the use of flag looks like no longer necessary if tracing mode parameter is set to 't'. Would it be acceptable to just add a new function sip_trace_mode() that will accept one parameter to specify what to track (message, transaction, dialog)? It would be a short form of sip_trace() with 3 parameters, when the two are not needed. I think it would be more coherent for the future to get rid of using also the message flag for tracking the transaction. Cheers, Daniel On 30.09.19 18:00, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >> It is about storing in database? Or also mirroring? > Storing to db. Don't know about mirroring. > > -- Juha

Hello, given the changes done in the module to track the message, transaction or dialog, it should be fine to do this right now, because it is the testing period for 5.3, where it is supposed to clean up of issue and make coherent the new changes for this release. It is not like a new brand feature, only how an existing feature can be used in config. Once there will be a release, removing the flag option won't be ok, because that can break existing configs in a stable release, right now we are still before such milestone. Cheers, Daniel On 01.10.19 10:11, Henning Westerholt wrote: > Hi Daniel, > > I like your suggestion about replacing the flag option with a function. > This duplication is IMHO another potential to confuse users, I see this > for the dialog module also frequently (dlg_flag vs. dlg_manage() ) > > If this change is to late for 5.3.0 - we could consider it for the next > development cycle. > > Cheers, > > Henning > > Am 30.09.19 um 20:22 schrieb Daniel-Constantin Mierla: >> Can you try with latest master? I pushed a commit that hopefully fixes it. >> >> On the other hand, the use of flag looks like no longer necessary if >> tracing mode parameter is set to 't'. Would it be acceptable to just add >> a new function sip_trace_mode() that will accept one parameter to >> specify what to track (message, transaction, dialog)? It would be a >> short form of sip_trace() with 3 parameters, when the two are not >> needed. I think it would be more coherent for the future to get rid of >> using also the message flag for tracking the transaction. >> >> Cheers, >> Daniel >> >> On 30.09.19 18:00, Juha Heinanen wrote: >>> Daniel-Constantin Mierla writes: >>> >>>> It is about storing in database? Or also mirroring? >>> Storing to db. Don't know about mirroring. >>> >>> -- Juha

Daniel-Constantin Mierla writes: Since this is quite a mess now (also RPC Commands section is confusing), it would be great if cleanup could be done before 5.3.

So trace_mode=1 and RPC commands should be effective also when HEP is not in use.