This fix try to solve the crash reported in http://lists.sip-router.org/pipermail/sr-users/2015-September/089846.html. The cause of the crash was that the sip message used to append branch was the shmem clone of the original message. When the new branches were going through their configured branch route, modifications done by other modules' function (like rtpproxy) were applied to this stored copy directly, causing the crash once a failure route was run. This patch take the same approach as the failure handler one, creating a fake request from the origin message and using this one to append branches. I am not sure if this is a good approach, since the appended branch are going through the branch route and some function called there could not be compatible with a faked request. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/346
-- Commit Summary --
* tm: fake msg and environment to append new branches
-- File Changes --
M modules/tm/t_append_branches.c (54)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/346.patch https://github.com/kamailio/kamailio/pull/346.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346
Not much time available today, but I am going to check it sometime soon.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346#issuecomment-143722304
Can be merged.
Anyhow, wondering if would be just enough to use a local temporary msg structure, will be simpler, but then if branch route is executed, some context attributes won't be there... I will try to analyze a bit more the whole concept with faking the environment, because sometimes could be just too complex for what exactly is needed.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346#issuecomment-146206212
Thanks for looking at it Daniel. If you prefer I can wait your analysis before merging.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346#issuecomment-146207063
If it fixes things now, merge it, refactoring can be done later.
Overall, is about not getting to fake the env too many times if same env can be re-used -- again, I need to look at other parts, it actually may not be the case for this situation.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346#issuecomment-146208337
Merged #346.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346#event-429175307
-
Daniel-Constantin Mierla -
Federico Cabiddu