[kamailio/kamailio] RPC fix for arrays on permissions module (#751)

List overview All Threads
Download

newer

older

[kamailio/kamailio] Async Routes...

git:master:cfb806e4: outbound: use...

kelchy

18 Aug 2016 18 Aug '16

6:42 p.m.

subnet dump and address dump You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/751 -- Commit Summary -- * fix rpc array for address * fix subnet rpc array -- File Changes -- M modules/permissions/hash.c (18) -- Patch Links -- https://github.com/kamailio/kamailio/pull/751.patch https://github.com/kamailio/kamailio/pull/751.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/751

Attachments:

attachment.html (text/html — 2.5 KB)

Show replies by date

Daniel-Constantin Mierla

18 Aug 18 Aug

8:24 p.m.

New subject: [kamailio/kamailio] RPC fix for arrays on permissions module (#751)

Can you try by setting RET_ARRAY flag to RPC exports at: * https://github.com/kamailio/kamailio/blob/master/modules/permissions/permis… Like at: * https://github.com/kamailio/kamailio/blob/master/modules/corex/corex_rpc.c#… If works, it should be the desired implementation in such case. Also, for the future, first line of the commit must be prefixed with the module name, see: * https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#co… -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/751#issuecomment-240811840

kelchy

19 Aug 19 Aug

9:12 a.m.

New subject: [kamailio/kamailio] RPC fix for arrays on permissions module (#751)

Kelvin Chua On Fri, Aug 19, 2016 at 2:24 AM, Daniel-Constantin Mierla < notifications(a)github.com> wrote:

...

Can you try by setting RET_ARRAY flag to RPC exports at: - https://github.com/kamailio/kamailio/blob/master/modules/ permissions/permissions.c#L1015 <https://github.com/kamailio/kamailio/blob/master/modules/permissions/permissions.c#L1015>

tried it, it changes the root but still returns 1 array element

...

Like at: - https://github.com/kamailio/kamailio/blob/master/modules/ corex/corex_rpc.c#L227 If works, it should be the desired implementation in such case. Also, for the future, first line of the commit must be prefixed with the module name, see: - https://github.com/kamailio/kamailio/blob/master/.github/ CONTRIBUTING.md#commit-message-format <https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format>

got it

...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/751#issuecomment-240811840>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGxwWN0qd-iYuyupIhZ6fXt4W3RT9Xyrks5qhKNogaJpZM4Jnr8L> .

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/751#issuecomment-240945331

kelchy

9:24 a.m.

New subject: [kamailio/kamailio] RPC fix for arrays on permissions module (#751)

Closed #751. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/751#event-760914170

Daniel-Constantin Mierla

9:34 a.m.

New subject: [kamailio/kamailio] RPC fix for arrays on permissions module (#751)

Have you closed because you plan a new pull request? Because I understand that my suggestion didn't fix it, or? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/751#issuecomment-240949159

kelchy

9:35 a.m.

New subject: [kamailio/kamailio] RPC fix for arrays on permissions module (#751)

closed, will create a new pull request Kelvin Chua On Fri, Aug 19, 2016 at 3:34 PM, Daniel-Constantin Mierla < notifications(a)github.com> wrote:

...

Have you closed because you plan a new pull request? Because I understand that my suggestion didn't fix it, or? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/751#issuecomment-240949159>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGxwWBsOCbARs7j-vdZvfvEiduIpO21oks5qhVyigaJpZM4Jnr8L> .

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/751#issuecomment-240949362

3025

days inactive

3026

days old

sr-dev@lists.kamailio.org

Manage subscription

5 comments

2 participants

tags (0)

participants (2)

Daniel-Constantin Mierla
kelchy