nmreistd created an issue (kamailio/kamailio#4247)
<!-- Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio....
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.or...
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months if there is no interest from developers or community users on pursuing it, being considered expired. In such case, it can be reopened by writing a comment that includes the token `/notexpired`. About two weeks before considered expired, the issue is marked with the label `stale`, trying to notify the submitter and everyone else that might be interested in it. To remove the label `stale`, write a comment that includes the token `/notstale`. Also, any comment postpone the `expire` timeline, being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment). -->
### Description
rtpengine module is now trying to ping previous permanently disabled nodes after commits: ``` * e183a3e25c rtpengine: Re-enable down servers (but not disabled ones) * 3823479733 rtpengine: Add timer to ping rtpengine ```
### Troubleshooting
#### Reproduction
Just create a set of nodes and also set at least one to be permanently disabled. After that do RPC `rtpengine.reload` or equivelent and after a `rtpengine.show all` and `disabled: 1(permanent)` will never show as before the aforementioned additions.
#### Debugging Data
<!-- If you got a core dump, use gdb to extract troubleshooting data - full backtrace, local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile bt full info locals list
If you are familiar with gdb, feel free to attach more of what you consider to be relevant. -->
``` (paste your debugging data here) ```
#### Log Messages
<!-- Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). -->
``` (paste your log messages here) ```
#### SIP Traffic
<!-- If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). -->
``` (paste your sip traffic here) ```
### Possible Solutions
<!-- If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix. -->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
``` Tested between `kamailio 5.8.2` and `6.0.1` ```
* **Operating System**:
<!-- Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...; Kernel details (output of `lsb_release -a` and `uname -a`) -->
``` debian bookworm ```
xkaraman left a comment (kamailio/kamailio#4247)
Hey @nmreistd ,
https://github.com/kamailio/kamailio/issues/3896 have you seen this by any chance?
there was a change on the disable value among others, to have only one type for easier parsing.
Could you verify that functionality-wise though is correct or is still bugged?
xkaraman left a comment (kamailio/kamailio#4247)
After some debugging it seems apart from the display issue, the pinging continued for disabled nodes. The check should probably re-evauluated since it's found in many other functions.
https://github.com/kamailio/kamailio/pull/4248 should fix this for the pinging timer interval at least!
@nmreistd can you maybe try this patch and confirm?