#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description pkg/kamailio/obs: Added support of OpenSUSE Tumbleweed pkg/kamailio/obs Fixed build of perl module pkg/kamailio: Added links to obs spec file for: - Fedora 25, 26 - RHEL 6, 7 - OpenSUSE Leap You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1241
-- Commit Summary --
* pkg/kamailio: Added links to obs spec file for: * pkg/kamailio/obs Fixed build of perl module * pkg/kamailio/obs: Added support of OpenSUSE Tumbleweed
-- File Changes --
A pkg/kamailio/fedora/25 (1) A pkg/kamailio/fedora/26 (1) M pkg/kamailio/obs/kamailio.spec (81) M pkg/kamailio/obs/meta (5) A pkg/kamailio/opensuse/1315 (1) A pkg/kamailio/opensuse/1330 (1) A pkg/kamailio/rhel/6 (1) A pkg/kamailio/rhel/7 (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1241.patch https://github.com/kamailio/kamailio/pull/1241.diff
Thanks for the PR and your significant contributions to rpm packaging.
But again I have to say that I am not confident the (sym)linking to obs folder is the right solution for other distributions. obs itself is by design an packing system for many distros. Just storing in the repo symlinks is creating some relations that should not be placed there.
As an idea that popped up right now in my mind, maybe it is better to have the folder rhel with a README.md and a Makefile inside. The makefile will have some rules to create subfolders for rhel versions (e.g., 6, 7...) that can be symlinks to obs if that works for packaging. The readme will explain that. Then the symlinks are created on the local copy of the person in need to do the packaging.
I know that there is a symlink for one of the packaging specs, but I find it confusing and not necessary to store it in the repo, being something needed to be created temporary.
Maybe we can discuss more during the irc devel meeting:
* https://www.kamailio.org/wiki/devel/irc-meetings/2017b
To conclude: I am fine to merge your updates, but remove those symlinking, let's discuss in the community how to do that properly.
I removed simlinking commit. I will try to attend a meeting
Thanks again, this work is really appreciated!
Merged #1241.
-
Daniel-Constantin Mierla -
sergey-safarov