<!-- Kamailio Pull Request Template --> ims_dialog bugfix for registering dialog callbacks ims_qos bugfix for Rx register dialog callback <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches --> 5.3 - [x] Tested changes locally --> Tested locally based on 5.1.6 - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> ims_dialog bugfix for registering dialog callbacks In Rx scenarios of parallel forking (several INVITEs with same CALLID and FROMTAG sent to PCSCF) and INVITE for orig and term handled in same PCSCF (means also INVITEs with identical CALLID and FROMTAG) the wrong dialog is selected for registering the callback (i.e. the callback for sending STR) when 200OK from terminator is processed. Root cause is that dialog is searched with callid-fromtag-totag but at the time of dialog insertion (processing of INVITE) no totag is available. fix is to get ctx dialog at 200OK processing before suspending the transaction - save dialog until AAA is received - use this dialog for registering the STR callback. ims_qos bugfix for Rx register dialog callback In some scenarios like parallel forking several INVITE with identical CALLID and FROMTAG sent to PCSCF which inserts dialogues for each INVITE. When 200OK is received in PCSCF the dialog callback must be registered for the respective dialog. Currently sometimes the wrong dialog is selected by searching with CALLID FROMTAG and TOTAG thus leading to problem no STR is sent at BYE. Fix is to pickup the right dialog before suspending the transaction during AAR/AAA processing and reuse this saved dialog after AAA reception for registering the dialog callback. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2263 -- Commit Summary -- * ims_dialog bugfix for registering dialog callbacks * ims_qos bugfix for Rx register dialog callback -- File Changes -- M src/modules/ims_dialog/dlg_cb.c (9) M src/modules/ims_dialog/dlg_cb.h (5) M src/modules/ims_dialog/dlg_handlers.c (1) M src/modules/ims_qos/ims_qos_mod.c (7) M src/modules/ims_qos/rx_aar.c (3) M src/modules/ims_qos/rx_aar.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2263.patch https://github.com/kamailio/kamailio/pull/2263.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2263