Hi,
the commit d0617167f0aebcaf1e12e6c7f77b2231aed9da51 broke Postgres on 4.2. It tries to zero variables which are not in 4.2.
From buildlog: km_pg_con.c: In function 'db_postgres_new_connection': km_pg_con.c:68: error: 'keywords' undeclared (first use in this function) km_pg_con.c:68: error: (Each undeclared identifier is reported only once km_pg_con.c:68: error: for each function it appears in.) km_pg_con.c:69: error: 'values' undeclared (first use in this function) km_pg_con.c:70: error: 'to' undeclared (first use in this function) make[1]: *** [km_pg_con.o] Error 1 make: *** [modules] Error 1
Hello,
I thought we have automatic builds via travis-ci for 4.2 and there was not error reported... not using postgres made it hard to discover it here.
I reverted it, can you confirm it goes on fine now?
Thanks, Daniel
On 23/11/15 16:39, Øyvind Kolbu wrote:
Hi,
the commit d0617167f0aebcaf1e12e6c7f77b2231aed9da51 broke Postgres on 4.2. It tries to zero variables which are not in 4.2.
From buildlog: km_pg_con.c: In function 'db_postgres_new_connection': km_pg_con.c:68: error: 'keywords' undeclared (first use in this function) km_pg_con.c:68: error: (Each undeclared identifier is reported only once km_pg_con.c:68: error: for each function it appears in.) km_pg_con.c:69: error: 'values' undeclared (first use in this function) km_pg_con.c:70: error: 'to' undeclared (first use in this function) make[1]: *** [km_pg_con.o] Error 1 make: *** [modules] Error 1
-- Cheers, Øyvind
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Yes, all god now. Thanks for the quick revert.
Maybe travis should attempt to build all modules?
Cheers, Øyvind
On 23.11.2015 16:50, Daniel-Constantin Mierla wrote:
Hello,
I thought we have automatic builds via travis-ci for 4.2 and there was not error reported... not using postgres made it hard to discover it here.
I reverted it, can you confirm it goes on fine now?
On 11/23/2015 05:07 PM, Øyvind Kolbu wrote:
Yes, all god now. Thanks for the quick revert.
Maybe travis should attempt to build all modules?
https://github.com/kamailio/kamailio/blob/4.2/test/travis/build_travis.sh
postgres is in the list of modules built
On 11/23/2015 05:21 PM, Victor Seva wrote:
On 11/23/2015 05:07 PM, Øyvind Kolbu wrote:
Yes, all god now. Thanks for the quick revert.
Maybe travis should attempt to build all modules?
https://github.com/kamailio/kamailio/blob/4.2/test/travis/build_travis.sh
postgres is in the list of modules built
And it was failing:
CC (gcc) [M db_postgres.so] km_pg_con.o km_pg_con.c: In function ‘db_postgres_new_connection’: km_pg_con.c:68:9: error: ‘keywords’ undeclared (first use in this function) km_pg_con.c:68:9: note: each undeclared identifier is reported only once for each function it appears in km_pg_con.c:69:9: error: ‘values’ undeclared (first use in this function) km_pg_con.c:70:9: error: ‘to’ undeclared (first use in this function) make[1]: *** [km_pg_con.o] Error 1 make: *** [modules] Error 1
The problem seems to be that the travis build script has not "set -e" !!
I will commit the fixes for travis ASAP
-
Daniel-Constantin Mierla -
Victor Seva -
Øyvind Kolbu