#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
we send "480 All servers busy" when no servers available for failover
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2602
-- Commit Summary --
* dispatcher: updated failover example
-- File Changes --
M src/modules/dispatcher/doc/dispatcher.cfg (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2602.patch https://github.com/kamailio/kamailio/pull/2602.diff
I am not really against, but also not seeing a real value on this approach, instead it can make troubleshooting harder for upstream, because it hides the downstream reply codes. In this case is about 500 or 408, but that can show a difference between a busy server and an unresponsive server.
Of course, there are cases when one wants to hide the downstream codes, but it is more likely a case per case specific.
Typically one has to edit that part of config to tune the list of reply codes for which to do re-routing.
On the other hand, the patch has syntax error, the opening `{` for `else` is missing.
Thanks, Daniel for the clarification.
Closed #2602.
-
Daniel-Constantin Mierla -
sergey-safarov