Module: kamailio Branch: master Commit: 67f71d1b7c44a7d3ef1ba2917272e2ba36608cd7 URL: https://github.com/kamailio/kamailio/commit/67f71d1b7c44a7d3ef1ba2917272e2b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-20T12:37:12+01:00 lib/xcap: reviewed and removed old comments and disabled code --- Modified: src/lib/xcap/common_policy.c Modified: src/lib/xcap/parse_common_rules.c Modified: src/lib/xcap/resource_list.c Modified: src/lib/xcap/xcap_client.c --- Diff: https://github.com/kamailio/kamailio/commit/67f71d1b7c44a7d3ef1ba2917272e2b… Patch: https://github.com/kamailio/kamailio/commit/67f71d1b7c44a7d3ef1ba2917272e2b… --- diff --git a/src/lib/xcap/common_policy.c b/src/lib/xcap/common_policy.c index a7d33d95d5d..0f887aa7ce7 100644 --- a/src/lib/xcap/common_policy.c +++ b/src/lib/xcap/common_policy.c @@ -175,7 +175,7 @@ int is_rule_for_uri(cp_rule_t *rule, const str_t *uri) if(!rule) return 0; if(!rule->conditions) - return 1; /* FIXME: ??? */ + return 1; id = rule->conditions->identity; if(!id) return 0; diff --git a/src/lib/xcap/parse_common_rules.c b/src/lib/xcap/parse_common_rules.c index 0e46ace7161..ca3f4599c06 100644 --- a/src/lib/xcap/parse_common_rules.c +++ b/src/lib/xcap/parse_common_rules.c @@ -211,13 +211,11 @@ static int read_conditions(xmlNode *cn, cp_conditions_t **dst) while(n) { if(n->type == XML_ELEMENT_NODE) { if(cmp_node(n, "validity", common_policy_ns) >= 0) { - /* FIXME: free existing validity */ res = read_validity(n, &(*dst)->validity); if(res != 0) break; } else { if(cmp_node(n, "identity", common_policy_ns) >= 0) { - /* FIXME: free existing identity */ res = read_identity(n, &(*dst)->identity); if(res != 0) break; diff --git a/src/lib/xcap/resource_list.c b/src/lib/xcap/resource_list.c index cb7d111057f..928c133df51 100644 --- a/src/lib/xcap/resource_list.c +++ b/src/lib/xcap/resource_list.c @@ -169,9 +169,9 @@ void free_traversed_list(traversed_list_t *list) /* ------- helper functions (doing flat list) ------- */ +/* absolute uri from ref (RFC 3986, section 5.2) */ static char *relative2absolute_uri(const str_t *xcap_root, const char *relative) { - /* FIXME: do absolute uri from ref (RFC 3986, section 5.2) */ int len; int root_len = 0; int rel_len = 0; diff --git a/src/lib/xcap/xcap_client.c b/src/lib/xcap/xcap_client.c index c633f3c7f5f..2fe6e41d1d6 100644 --- a/src/lib/xcap/xcap_client.c +++ b/src/lib/xcap/xcap_client.c @@ -284,13 +284,8 @@ int xcap_query( /* follow redirects (needed for apache mod_speling - case insesitive names) */ curl_easy_setopt(handle, CURLOPT_FOLLOWLOCATION, 1); - /* curl_easy_setopt(handle, CURLOPT_TCP_NODELAY, 1); - curl_easy_setopt(handle, CURLOPT_CONNECTTIMEOUT, 10);*/ - /* Accept headers */ - res = curl_easy_perform(handle); - /* curl_easy_cleanup(handle); */ /* FIXME: experimental */ } else ERROR_LOG("can't initialize curl handle\n"); if(res == 0) {