<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally against Version 5.1.0 - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> When old (maybe forgotten) Contacts expire in S-CSCF, then current - wanted - calls will be deleted, which is not wanted. Reason is the usage of "=" Operator instead "==" Operator in ims_usrloc_scscf module.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1539
-- Commit Summary --
* ims_usrloc_scscf: bugfix Contct is removed when old Contct expires * removed KCCVICT tagging * Merge branch 'bugfix_prm18_0000756_trash_expires' into bugfix_trash_expires
-- File Changes --
M src/modules/ims_usrloc_scscf/impurecord.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1539.patch https://github.com/kamailio/kamailio/pull/1539.diff
@christoph-v can you please send this change as one commit, please. ``git rebase -i origin/master`` and ``git push --force`` are your friends
Should be reduced to one commit, now. Please try again
SurendraPlivo commented on this pull request.
did you tested those changes ?
@ngvoice - any comment on this change? It looks like a simple fix, but better to have a second review on it.
Merged #1539.
@SurendraPlivo : yes, we tested the fix with following test case: 1) Register first contact (expires 3600) 2) Register second contact (expires 120) 3) Initiate call from first contact 4) wait a few minutes 5) Call should NOT be torn down by S-CSCF, when second contact expires (without fix, it IS) 6) send bye, end the test case