<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Skip cdr generation for dialogs with this dlg_var set. This is analogue to parameter in acc module. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4323
-- Commit Summary --
* acc_json: add cdr_skip parameter
-- File Changes --
M src/modules/acc_json/acc_json_mod.c (16) M src/modules/acc_json/doc/acc_json_admin.xml (18)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4323.patch https://github.com/kamailio/kamailio/pull/4323.diff
miconda left a comment (kamailio/kamailio#4323)
Fine for me to merge it.
As a side remark, there are dialog flags that could be used in a similar case, they are simpler in term of storage, but I am not sure if the is intermodule API to access them from other modules.
lbalaceanu left a comment (kamailio/kamailio#4323)
Thank you. I will merge.
Merged #4323 into master.