Module: sip-router Branch: 3.1 Commit: 252fcd963637e92727e58f6c1b84bf06200eee12 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=252fcd96...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Wed Oct 6 12:27:28 2010 +0200
kamctl: lcr commands disabled
- only left enabled is the one related to weights - the commands were not using latest db schema - Juha suggested handling lcr via kamctl is too complex to scale, so commands are disabled until new code is contributed
---
utils/kamctl/kamctl | 16 +++++++++++++--- 1 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index 48db7dd..5108420 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -1116,25 +1116,35 @@ trusted() { lcr() { case $1 in show_gws) + merr "command disabled" + exit; require_dbengine mecho "lcr gateways" QUERY="select * FROM $GW_TABLE ORDER BY $LCR_ID_COLUMN, $LCR_GW_GRPID_COLUMN; " $DBROCMD "$QUERY" ;; show_routes) + merr "command disabled" + exit; require_dbengine mecho "lcr routes" QUERY="select * FROM $LCR_TABLE ORDER BY $LCR_ID_COLUMN, $LCR_PREFIX_COLUMN; " $DBROCMD "$QUERY" ;; reload) - $RPCCMD lcr.reload + merr "command disabled" + exit; + $CTLCMD lcr.reload ;; dump_gws) - $RPCCMD lcr.dump_gws + merr "command disabled" + exit; + $CTLCMD lcr.dump_gws ;; dump_routes) - $RPCCMD lcr.dump_lcrs + merr "command disabled" + exit; + $CTLCMD lcr.dump_lcrs ;; eval_weights) shift
2010/10/6 Daniel-Constantin Mierla miconda@gmail.com:
show_routes)
- merr "command disabled"
- exit;
Hi, shouldn't these disabled command terminate with error status code (exit 1)?