<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #1265
#### Description Add columns referenced by [p_usrloc_mod.c](https://github.com/kamailio/kamailio/blob/6c01e2692d5ff56dda54d21469d32c4d3d...) You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1266
-- Commit Summary --
* p_usrloc: Fix #1265: missing columns in location.sql file.
-- File Changes --
M src/modules/p_usrloc/location.sql (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1266.patch https://github.com/kamailio/kamailio/pull/1266.diff
Merged #1266.
Thank you for your fix.
Are these changes done first in the xml schema with table definition from src/lib/srdb1/schema? If done only in sql files, then it is done in the wrong place.
Hello Daniel,
location.sql is the only changed file. I see in the src/lib/srdb1/schema/location.sql that this is documented as belonging to usrloc and that the columns are present there.
Should I create a similar xml for p_usrloc used tables?
Thank you
Ohh, actually the sql file was in the module folder, I thought is in the utils/kamctl/{mysql,postgres,...}. So it is in the wrong place.
Yes, the best is to create xml definition as for location (usrloc module), then you can do 'make dbschema' to get the sql files generated. You may need to update the Makefile in the schema folder.
-
Andrew Siplas -
Daniel-Constantin Mierla
-
Lucian Balaceanu