Module: sip-router Branch: master Commit: c737bb20f2ce9158bfce6f175c02907acd8b0617 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c737bb20...
Author: Juha Heinanen jh@tutpro.com Committer: Juha Heinanen jh@tutpro.com Date: Tue Apr 21 19:30:43 2009 +0300
* Module: presence
Introduced a dew function auth_status() that can be used to check from script if a watcher is allowed to subscriber event 'presence' of a presentity.
---
modules_k/presence/README | 228 ++++++++++++++++------------- modules_k/presence/doc/presence.xml | 23 +++- modules_k/presence/doc/presence_admin.xml | 30 ++++ modules_k/presence/presence.c | 96 ++++++++++++ 4 files changed, 274 insertions(+), 103 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c737...
Hello,
On 04/21/2009 06:33 PM, Juha Heinanen wrote:
Module: sip-router Branch: master Commit: c737bb20f2ce9158bfce6f175c02907acd8b0617 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c737bb20...
Author: Juha Heinanen jh@tutpro.com Committer: Juha Heinanen jh@tutpro.com Date: Tue Apr 21 19:30:43 2009 +0300
- Module: presence
Introduced a dew function auth_status() that can be used to check from script if a watcher is allowed to subscriber event 'presence' of a presentity.
wouldn't be better to have this function named: watcher_auth_status() (or ps_auth_status() - ps from presence server, or other prefix like pres, presence)? It will be more suggestive about provided functionality.
Cheers, Daniel
modules_k/presence/README | 228 ++++++++++++++++------------- modules_k/presence/doc/presence.xml | 23 +++- modules_k/presence/doc/presence_admin.xml | 30 ++++ modules_k/presence/presence.c | 96 ++++++++++++ 4 files changed, 274 insertions(+), 103 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c737...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Daniel-Constantin Mierla writes:
wouldn't be better to have this function named: watcher_auth_status() (or ps_auth_status() - ps from presence server, or other prefix like pres, presence)? It will be more suggestive about provided functionality.
presence module has in its api a function called 'get_auth_status'. i just more or less reused the name so if someone reads presence module readme, he/she can easily associate those two.
-- juha
On 04/21/2009 06:59 PM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
wouldn't be better to have this function named: watcher_auth_status() (or ps_auth_status() - ps from presence server, or other prefix like pres, presence)? It will be more suggestive about provided functionality.
presence module has in its api a function called 'get_auth_status'. i just more or less reused the name so if someone reads presence module readme, he/she can easily associate those two.
internally it is used via some structure, like pres.get_auth_status(). In config we do not have that. Lot of functions have different names in C and config.
As it is now, function name suggest more sip auth status with no relation to presence or watcher. Just my opinion. We had discussions in the past how to make names for suggestive in relation with provided functionality and the module that exports them.
Daniel
Daniel-Constantin Mierla writes:
As it is now, function name suggest more sip auth status with no relation to presence or watcher. Just my opinion. We had discussions in the past how to make names for suggestive in relation with provided functionality and the module that exports them.
one solution could be to use module.function.
but i can change the name to pres_auth_status, once i can generate the readme file in sip-router repo.
-- juha
On 04/21/2009 07:08 PM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
As it is now, function name suggest more sip auth status with no relation to presence or watcher. Just my opinion. We had discussions in the past how to make names for suggestive in relation with provided functionality and the module that exports them.
one solution could be to use module.function.
but i can change the name to pres_auth_status,
it was just a suggestion, in case you find it better, as well.
Thanks, Daniel
once i can generate the readme file in sip-router repo.
-- juha
Juha Heinanen schrieb:
Daniel-Constantin Mierla writes:
As it is now, function name suggest more sip auth status with no relation to presence or watcher. Just my opinion. We had discussions in the past how to make names for suggestive in relation with provided functionality and the module that exports them.
one solution could be to use module.function.
but i can change the name to pres_auth_status, once i can generate the readme file in sip-router repo.
I second that. auth_status may imply that this is a generic authentication function.
regards klaus
-
Daniel-Constantin Mierla -
jh＠tutpro.com -
Juha Heinanen
-
Klaus Darilion