sr-users

sr-users@lists.kamailio.org

14 participants
37465 discussions

new functionality: CDR-based accounting
by Timo Reimann 19 Aug '11

19 Aug '11

Hi all, as announced quite a while ago, I finally checked in code that allows to produce CDRs (Call Data Records) directly from SIP-Router and generate logs accordingly. The main code portion resides in modules_k/acc and provides a switch to enable basic CDR generation including start time, end time, and duration. Analogous to the existing logging approach, you may define an extra parameter covering to-be-included dialog pseudo-variables that must be assigned in the configuration script. The … [View More]

5 7

LCR Modules Comparison
by Spencer Thomason 19 Aug '11

19 Aug '11

Hello all, Can anyone shed some light into the differences between the available LCR modules? We have migrated our config from OpenSIPS where we used the drouting module to Kamailio where we are using the lcr module. Our ruleset is not crazy huge, about 100k entries. Are there compelling reasons to choose one module over the other? Is there one that has the most active development behind it and is a "standard" for the platform or is there one that will be deprecated in the foreseeable future? Thanks, Spencer

4 3

Re: [SR-Users] decode_mime_type error
by Bucur Marius 19 Aug '11

19 Aug '11

Hi Jijo, In my opinion, decode_mime_type is broken, and parse_accept_body does not work as expected. For example, this is a valid accept header: accept: text/plain;param=",some value". but the parse_accept_body will return -1 because the first return value of decode_mime_type is ",some value\"". The second invocation will think "some value\"" is a mime type, which obviously isn't. I must say I never saw such an accept header, but the standard permits it. Indeed, a quick fix would be … [View More]to ignore the return code when comma is found. This must be done for other functions that call decode_mime_type like has_body(mime) in textops. This is just my opinion, but I think this solution is a bit hackish since the convention, the "promise" that decode_mime_type should respect is to return a non-NULL, non-end pointer ONLY when there are more mime types in the body. And it doesn't. A lot of functions that call it rely on this. I think it is easier/more elegant to fix the bug in the decode_mime_type then to change the function convention in all callers. Also, this might work for most callers, but parse_accept_body will still be buggy, as I explained in the example above. Cheers, Marius ________________________________ From: Jijo <realjijo(a)gmail.com> To: Bucur Marius <bucur_marius_ovidiu(a)yahoo.com> Sent: Thursday, August 18, 2011 10:48 AM Subject: Re: [SR-Users] decode_mime_type error Hi Marius, Right, the same function is used for Accept and Content-Type. I don't think there is any change required for parsing Accept. In case of Accept the function decode_mime_type is called in a loop until it find all the media types. On the returning from decode_mime_type(), the main function parse_accept_xxx() checks the pointer is 'comma' or not. if its comma, then the function decode_mime_type called again and find the remaining media types. So i think the existing implementation for Parsing Accept is fine. The only change required here is not return error for comma while parsing the Content-Type. Thanks Jijo On Thu, Aug 18, 2011 at 12:32 PM, Bucur Marius <bucur_marius_ovidiu(a)yahoo.com> wrote: Hello Jijo, > >You are right, multiple mime-types are not allowed. But it seems like decode_mime_type had the purpose of also parsing the Accept header: > >Accept: text/html, image/jpeg, multipart > >hence the search for commas :). >The only function that uses this feature and calls decode_mime_type in a loop is parse_accept_body. The other functions that call decode_mime_type just fail when returning ret != end, and since multiple mime types in content-type are not allowed the behavior is fine. >The bad thing is the Accept header can have mime parameters too (which can contain comma). > >Accept = "Accept" HCOLON [ accept-range *(COMMA accept-range) ] >accept-range = media-range *(SEMI accept-param) >media-range = ( "*/*" / ( m-type SLASH "*" ) / ( m-type SLASH m-subtype ) ) *( SEMI m-parameter ) > >So I think the best thing would be to change decode_mime_type so that it does a more thorough parsing (e.g. check for parameter) hence a parameter value can contain commas (only if quoted). > > >Cheers, > >Marius >________________________________ >From: Jijo <realjijo(a)gmail.com> >To: Bucur Marius <bucur_marius_ovidiu(a)yahoo.com>; SIP Router - Kamailio (OpenSER) and SIP Express Router (SER) - Users Mailing List <sr-users(a)lists.sip-router.org> >Sent: Thursday, August 18, 2011 8:04 AM >Subject: Re: [SR-Users] decode_mime_type error > > > >Hi Marius, > >Thanks for the response.. I checked the other functions, but they don't have the check for ret !=end, but they check the pointer and if it is comma then loop through again until it find all the media types. > >As per the RFC3261 multiple media-types are not supoorted in the Content-Type. So I'm not sure why the author used comma to determine multiple media types . Probably just followed like Route or Record-Route headers..?? > >Content-Type = ( "Content-Type" / "c" ) HCOLON media-type >media-type = m-type SLASH m-subtype *(SEMI m-parameter) >m-type = discrete-type / composite-type >discrete-type = "text" / "image" / "audio" / "video" >/ "application" / extension-token >composite-type = "message" / "multipart" / extension-token > >Record-Route = "Record-Route" HCOLON rec-route *(COMMA rec-route) > >Thanks >Jijo > > > >On Thu, Aug 18, 2011 at 2:23 AM, Bucur Marius <bucur_marius_ovidiu(a)yahoo.com> wrote: > >Hello Jijo, >> >>It seems like the decode_mime_type is a somehow broken. The comma is very well allowed in boundary, as you said. The BNF specified in RFC2046 permits it. >>But, the decode_mime_type function ignores everything coming after comma. More than that, it notifies the function caller that this content type has multiple mime types. >>I think the author of the function thought of something like: >> >>Content-Type: text/html, image/jpeg // very weird, though >> >>This is wrong, hence the comma can be in a parameter (like in your case). >>I think the best fix, as you said is to remove that check, hence a non-NULL return value doesn't mean anything (that the content type has multiple mime types). >>Another fix is to write a "good" decode_mime_type, that checks if the comma is inside a parameter. I don't know if effort is worth it. >> >>One thing we need to do is to check if there are any functions in Kamailio that call decode_mime_type and also perform this check (ret != end). >> >>Cheers, >>Marius >> >> >>________________________________ >>From: Jijo <realjijo(a)gmail.com> >>To: sr-users(a)lists.sip-router.org; sr-dev(a)lists.sip-router.org >>Sent: Wednesday, August 17, 2011 10:54 AM >>Subject: [SR-Users] decode_mime_type error >> >> >> >>Hi All, >> >>The function parse_content_type_hdr() is failing in decode_mime_type() when Content-Type parameter "boundary" has value comma as below. The error message is "ERROR:parse_content_type_hdr: CONTENT_TYPE hdr contains " >> "more then one mime type :-(! >> >>Content Type Header is as below, It works fine if the boundary value is without comma. >> >>Content-Type: multipart/mixed;boundary=",AW" >> >>The parse_content_type_hdr() is failing in the following code, >> >> ret = decode_mime_type(msg->content_type->body.s, end , &mime); >> if (ret==0) >> goto error; >> if (ret!=end) { >> >> LOG(L_INFO,"ERROR:parse_content_type_hdr: CONTENT_TYPE hdr contains " >> "more then one mime type :-(!\n"); >> goto error ; >> } >> >>I thought of fixing this issue by commenting the code for condition ret !=end. I'm not sure why we we need that check, as mime variable has the information to process the content. >> >>Please let me know if you see any impact. >> >>Thanks >>Jijo >> >> >> >> >> >>_______________________________________________ >>SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >>sr-users(a)lists.sip-router.org >>http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users >> >>_______________________________________________ >>SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >>sr-users(a)lists.sip-router.org >>http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users >> > [View Less]

2 1

The not so simple Kamailio Load Balancing of Asterisk
by Nick Khamis 19 Aug '11

19 Aug '11

Hello Everyone, I saw the simple load balancing of asterisk using x-SER documentation here "http://www.kamailio.org/dokuwiki/doku.php/asterisk:load-balancing-and-ha". Are there any up-tp-date not so simple documentation for setting up HA and LB asterisk instances using x-SER. Thanks in Advance, Nick Khamis Toronto Hydro Telecom

5 7

decode_mime_type error
by Jijo 18 Aug '11

18 Aug '11

Hi All, The function parse_content_type_hdr() is failing in decode_mime_type() when Content-Type parameter "boundary" has value comma as below. The error message is "ERROR:parse_content_type_hdr: CONTENT_TYPE hdr contains " "more then one mime type :-(! Content Type Header is as below, It works fine if the boundary value is without comma. Content-Type: multipart/mixed;boundary="*,*AW" The parse_content_type_hdr() is failing in the following code, ret = decode_mime_type(msg-… [View More]

2 2

Re: [SR-Users] mtree question
by Javier Gallart 18 Aug '11

18 Aug '11

Hi Juha based on my experience with the mtree module: -mt_match() will match the longest prefix in the tree, in your case 00358 -mt_ignore_duplicates makes sense when loading the data in the DB to the memory. There could be duplicate entries in the db and with that directive you tell kamailio how to handle that situation -I don't know about mt_tree_type...(never needed to test it) Hope it helps Regards Javi > ------------------------------ > > Message: 2 > Date: Fri, 12 Aug … [View More]

3 5

lookup for specified user
by Efelin Novak 17 Aug '11

17 Aug '11

Hi folks, I discussed this issue in previous email ( [SR-Users Modifying $rU after lookup() ) but the question is a bit different now. I would like to change uri like lookup() function does it, but for the specific user. Problem is I want to have one registration (X) for several numbers. When this number is called I have to perform lookup() for this one common registration (X) and send this call there. To do this I changed $rU just before lookup() for X, and after lookup() I … [View More]

3 5

siptrace loosing an ACK
by Timo Klecker 17 Aug '11

17 Aug '11

Hello We are using the siptrace module to save the sip-messages to our database. All the messages are logged except one message. After INVITE, 100 trying and 200 OK we loose the outbound ACK which is forwarded by Kamailio statelessly in t_funcs.c. Is there any way to get a siptrace of this message, too? I've made a picture of the sip-messages and the lost ACK. Kind regards Timo Klecker

3 3

Error message
by Jon Bonilla 16 Aug '11

16 Aug '11

I have an error message in kamailio's log repeated many times. I tried to google it but no results (I think it's forst time I see no results in a google search) /usr/sbin/kamailio[3769]: ERROR: ctl [binrpc_run.c:942]: ERROR: binrpc: rpc_printf: binrpc_addstr failed: buffer too small (overflow) (-2) What does it mean? Any ideas? thanks, Jon

2 1

openSIPS vs Kamailio vs SIP-Router
by Nick Khamis 15 Aug '11

15 Aug '11

Hello Everyone, I can only imagine how many times this question has come up since post 2008. Please forgive my reoccurring of the issue. We are looking to provide carrier grade sip services to our clients world wide. What we need is a lightweight, robust and scalable solution that will allow us to terminate sip calls to our different carriers. Performance, and high throughput are factors very important to my employer. Features such as caller authentication, database back-end, load balancing, … [View More]

4 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

sr-users