-----Original Message-----
From: Daniel-Constantin Mierla [mailto:daniel@voice-system.ro]
Sent: Monday, July 09, 2007 12:10 PM
To: Papadopoulos Georgios
Cc: users(a)openser.org
Subject: Re: [OpenSER-Users] crash when checking empty destination uri
Hello George,
if loose_route returns true, the $du should be set. Can you
send me a sample of such ACK along with the backtrace?
Cheers,
Daniel
On 07/09/07 10:52, Papadopoulos Georgios wrote:
Hi Daniel,
Thank you for looking into this. I got from SVN the patch for rev.
2420 and I applied it to my 1.2 branch. OpenSER still
crashes at the
same point. Did I get the right patch? The one I
have
changes one line
on route.c and transformations.c. I will add it
at the end
of the email.
Best regards
George
Index: route.c^M
===================================================================^M
--- route.c (revision 2419)^M
+++ route.c (revision 2420)^M
@@ -446,6 +446,9 @@^M
char backup2;
str res;
xl_value_t value;
+
+ if(ival==NULL || ival->s==NULL)
+ goto error;
res.s = 0; res.len = 0;
if(opd->type == SCRIPTVAR_ST)
Index: transformations.c^M
===================================================================^M
--- transformations.c (revision 2419)^M
+++ transformations.c (revision 2420)^M
@@ -71,7 +71,8 @@^M
char *p, *s;
str st;
xl_value_t v;
- if(val==NULL)
+
+ if(val==NULL || val->flags&XL_VAL_NULL)
return -1;
switch(subtype)
> -----Original Message-----
> From: Daniel-Constantin Mierla [mailto:daniel@voice-system.ro]
> Sent: Friday, July 06, 2007 9:19 PM
> To: Papadopoulos Georgios
> Cc: users(a)openser.org
> Subject: Re: [OpenSER-Users] crash when checking empty destination
> uri
>
> Hello,
>
> On 07/06/07 17:09, Papadopoulos Georgios wrote:
>
>
>> Hello,
>>
>> I have the following line in my script which causes OpenSER
>>
>>
> (1.2) to
>
>
>> crash when the execution gets there for an ACK.
>> if ($du=~"[@:](192\.168\.|10\.|172\.(1[6-9]|2[0-9]|3[0-1])\.)")
>> It gets at this line when an ACK is received and after
>>
>>
> loose_route()
>
>
>> returns true. So I am guessing the destination uri is
>>
null at that
>> point and the check causes OpenSER to
crash.
>>
>> If I add the following check then everything works fine.
>> if (isdsturiset() &&
>> $du=~"[@:](192\.168\.|10\.|172\.(1[6-9]|2[0-9]|3[0-1])\.)")
>>
>>
> can you test with devel version? I applied a patch, and if
>
ok, I will
> backport. Thanks for reporting.
>
> Cheers,
> Daniel
>
>
>
>>
>> thank you
>>
>> George
>>
>>
>>
>> Disclaimer
>>
>> The information in this e-mail and any attachments is
>>
>>
> confidential. It
>
>
>> is intended solely for the attention and use of the named
>> addressee(s). If you are not the intended recipient, or person
>> responsible for delivering this information to the intended
>>
>>
> recipient,
>
>
>> please notify the sender immediately. Unless you are the intended
>> recipient or his/her representative you are not
>>
authorized to, and
>> must not, read, copy, distribute, use or
retain this
>>
message or any
>> part of it. E-mail transmission cannot be
guaranteed to be
>>
>>
> secure or
>
>
>> error-free as information could be intercepted, corrupted, lost,
>> destroyed, arrive late or incomplete, or contain viruses.
>>
>>
>>
>>
---------------------------------------------------------------------
>> -
>>
>>
>>> --
>>>
>>> _______________________________________________
>>> Users mailing list
>>> Users(a)openser.org
>>>
http://openser.org/cgi-bin/mailman/listinfo/users
>>>
>>>
>>>
>
>