Re: [SR-Users] Unquoted values from #!defenv

Daniel, Is the #!defenvs feature still a work in progress? I wrote a change to add #!defenvn and #!defenvns to allow for undefined environmental variables, and noticed that the string quoting on #!defenvs doesn't do anything except log the quoting mode in /src/core/ pp_define_set(). Ben Kaufman Sr. VoIP Engineer P: E: bkaufman@bcmone.com<mailto:bkaufman@bcmone.com> 24 hour client support: 855.639.6300<tel:+18556396300> From: sr-users &lt;sr-users-bounces(a)lists.kamailio.org&gt; On Behalf Of Ben Kaufman Sent: Tuesday, December 7, 2021 9:12 AM To: Kamailio (SER) - Users Mailing List &lt;sr-users(a)lists.kamailio.org&gt; Subject: Re: [SR-Users] Unquoted values from #!defenv Thank you. I've been using -A to set values thus far as CMD arguments to the container's ENTRYPOINT. If submitting a pull request, would it be preferrable to allow #!defenv/#!defenvs to accept undefined values, or to add new keywords like #!ifdefenv/#!ifdefenvs ? Ben Kaufman From: Daniel-Constantin Mierla <miconda@gmail.com<mailto:miconda@gmail.com>> Sent: Tuesday, December 7, 2021 2:22 AM To: Ben Kaufman <bkaufman@bcmone.com<mailto:bkaufman@bcmone.com>>; Kamailio (SER) - Users Mailing List <sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org>> Subject: Re: [SR-Users] Unquoted values from #!defenv The current behaviour targets the use of existing values from the environment variables. If you need other kind of features, you can propose pull requests. Or you can eventually have a start script that sets defines with -A cli parameter based on env variables. Cheers, Daniel On 06.12.21 21:56, Ben Kaufman wrote: Thank you :) A follow up question would be on the usability of the #!defenv (and probably #!defenvs) usability with #!ifdef. In the scenario below, if the environmental variable WITH_DEBUGGER is not defined, then Kamailio will fail to start, thus the #!ifdef is somewhat limited. It makes sense for scenarios where someone might toggle the setting editing the config file, but it would be very convenient to toggle the environmental variable instead, particularly in containerized environments. Any thoughts on how best to control this? #!defenv WITH_DEBUGGER #!ifdef WITH_DEBUGGER loadmodule "debugger" . . . #!endif Ben Kaufman From: Daniel-Constantin Mierla <miconda@gmail.com><mailto:miconda@gmail.com> Sent: Monday, December 6, 2021 3:55 AM To: Kamailio (SER) - Users Mailing List <sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>; Ben Kaufman <bkaufman@nexvortex.com><mailto:bkaufman@nexvortex.com> Subject: Re: [SR-Users] Unquoted values from #!defenv Hello, #!substdef does not set the value inside quoted string, it replaces inside a string value, so it does not put quotes around replacement part. So it does it it is written in the docs. There is #!substdefs witch can create a define with quoted value. Note that defines are standalone-token replacement, you can define an ID to a number, to a keyword (e.g., src_ip), to a quoted string or even a multi-line script snippet, like: #!define IDLOOP $var(i) = 0; \ while($var(i)<5) { \ xlog("++++ $var(i)\n"); \ $var(i) = $var(i) + 1; \ } See the core cookbook for more details. Anyhow, as using env variable values as quoted string is useful and setting them with quotes might look odd, I added #!defenvs: * https://www.kamailio.org/wiki/cookbooks/devel/core#defenvs<https://nam11… Cheers, Daniel On 30.11.21 22:40, Ben Kaufman wrote: Hello all, Looking for some clarification regarding quoting and !#defenv . I understand that the example below fails because the environmental variable HOME is not quoted, thus when used in the xlog() call it fails. How is it possible to evaluate and/or use the value of the environmental variable if defined as a preprocessor variable? Looking at the documentation the reason for this directive is "It is a simplified alternative of using #!substdef with $env(NAME) in the replacement part." But #!substdef would allow setting the value inside of a quoted string, so does it really meet that requirement? I'm aware that I could use $env(HOME) rather than a preprocessor directive of HOME. I'm just trying to understand the usage of the #!defenv feature. #!KAMAILIO ## Tested in 5.5.2 loadmodule "xlog" loadmodule "pv" loadmodule "evrexec" modparam("evrexec", "exec", "name=evrexec:timer;wait=1000;workers=1;") #!defenv HOME request_route{ forward(); } event_route[evrexec:timer] { xlog("L_N", "HOME: " + HOME + "\n"); } Ben Kaufman __________________________________________________________ Kamailio - Users Mailing List - Non Commercial Discussions * sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org> Important: keep the mailing list in the recipients, do not reply only to the sender! Edit mailing list options or unsubscribe: * https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users<https://nam… -- Daniel-Constantin Mierla -- www.asipto.com<https://nam11.safelinks.protection.outlook.com/?url=http%… www.twitter.com/miconda<https://nam11.safelinks.protection.outlook.com/?… -- www.linkedin.com/in/miconda<https://nam11.safelinks.protection.outlook.c… Kamailio Advanced Training - Online Feb 21-24, 2022 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/<https://nam… -- Daniel-Constantin Mierla -- www.asipto.com<https://nam11.safelinks.protection.outlook.com/?url=http%… www.twitter.com/miconda<https://nam11.safelinks.protection.outlook.com/?… -- www.linkedin.com/in/miconda<https://nam11.safelinks.protection.outlook.c… Kamailio Advanced Training - Online Feb 21-24, 2022 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/<https://nam…