Best regards,
Santi
I checked it quickly and the only thing that does not seem ok is how
the r-uri is taken in modules/dialog/dlg_handlers.c:
- instead of:
+ if(parse_orig_ruri(msg)< 0) {
+ LM_ERR("bad request or missing RURI\n");
+ return -1;
+ }
+
should be:
+ if(parse_sip_msg_uri(msg)< 0) {
+ LM_ERR("bad request or missing RURI\n");
+ return -1;
+ }
+
and instead of:
+ &(msg->first_line.u.request.uri) );
should be
+ GET_RURI(msg) );
This ensures that latest R-URI value is taken -- you used to get
original r-uri.
If someone can test and report, I will commit quickly.
Cheers,
Daniel
On 12/16/09 4:07 PM, Francisco Javier Lizarán Vilches wrote:
-----Mensaje original-----
De: users-bounces(a)lists.kamailio.org
<mailto:
users-bounces(a)lists.kamailio.org> [mailto:
users-bounces(a)lists.kamailio.org]
En nombre de Daniel-Constantin Mierla
Enviado el: miércoles, 16 de diciembre de 2009 10:38
Para: David
CC: users(a)lists.kamailio.org <mailto:users@lists.kamailio.org>
Asunto: Re: [Kamailio-Users] Presence_Dialoginfo versioning
On 12/15/09 4:37 PM, David wrote:
> OK, it turns out that the presence application is properly updating
> subscriptions within a dialog, and creating new subscriptions
> outside
> a dialog.
>
> The difficultly is that I am rewriting the To: header, since I used
> dirty tools, it was dropping ;tag=, so the server thought it was a
> new
> dialog and the phone the same dialog.
>
>
This should be fixed once r-uri is used instead of To header, right?
I
am trying to find some time to fix it, maybe with a mod param option.
Cheers,
Daniel
Hi Daniel,
Some time ago we posted a patch to try to accomplish what you mention:
http://sip-router.org/tracker/index.php?do=details&task_id=18 <
http://sip-router.org/tracker/index.php?do=details&task_id=18>
Hope it helps.
Regards:
Francisco
> I am testing to make sure that the issue is resolved.
>
> David
>
>
>
> On 2009-12-15 04:12, Olle E. Johansson wrote:
>
>
>> 15 dec 2009 kl. 09.59 skrev Daniel-Constantin Mierla:
>>
>>
>>
>>> Hello,
>>>
>>>
>>> On 12/15/09 2:20 AM, kamailio.org(a)spam.lublink.net <mailto:
>>> kamailio.org(a)spam.lublink.net> wrote:
>>>
>>>
>>>> Alright, I finally found the proper RFC,
>>>>
http://www.rfc-editor.org/rfc/rfc4235.txt
>>>>
>>>> Section 4.1 :
>>>>
>>>> "version: This attribute allows the recipient of dialog
>>>> information documents to properly order them. Versions start at
>>>> 0,
>>>> and increment by one for each new document sent to a subscriber.
>>>> Versions are scoped within a subscription. Versions MUST be
>>>> representable using a non-negative 32 bit integer."
>>>>
>>>> Versions are scoped within a subscription, so when a new
>>>> subscription is started, ( after the 1 hour expiry ), the version
>>>> should be reset as it is a new subscription and therefore a new
>>>> scope ?
>>>>
>>>> When the subscription expires, is it renewed or is a new
>>>> subscription created? Is the scope separate, or is it the same
>>>> subscription updated?
>>>>
>>>>
>>> I think this is another questionable thing about SIP. IMO, it is
>>> same subscription if the dialog attributes do not change (call-id,
>>> from tag and to tag). But others can argue is it a new
>>> subscription.
>>> Anyone else on this one?
>>>
>>>
>>>
>> The proper RFC for generic subscription/notify questions is RFC
>> 3265.
>>
>> "3.1.1 Subscription Duration
>> SUBSCRIBE requests SHOULD contain an Expires header (defined in SIP
>> [2]). This expires value indicates
>> the duration of the subscription. In order to keep subscriptions
>> effective beyond the duration communicated
>> in the Expires header, subscribers need to refresh subscriptions on
>> a
>> periodic basis using a new
>> SUBSCRIBE message on the same dialog as defined in SIP [2]"
>>
>> This indicates to me that it's the same subscription as long as you
>> refresh it.
>>
>> RFC4235 refers to RFC 3265 for general terminology about
>> subscriptions.
>>
>> /O
>>
>>
> _______________________________________________
> Kamailio (OpenSER) - Users mailing list
> Users(a)lists.kamailio.org <mailto:Users@lists.kamailio.org>
>
>
http://lists.kamailio.org/cgi-bin/mailman/listinfo/users
>
http://lists.openser-project.org/cgi-bin/mailman/listinfo/users
>
>
>
--
Daniel-Constantin Mierla
*
http://www.asipto.com/
_______________________________________________
Kamailio (OpenSER) - Users mailing list
Users(a)lists.kamailio.org <mailto:Users@lists.kamailio.org>
http://lists.kamailio.org/cgi-bin/mailman/listinfo/users
http://lists.openser-project.org/cgi-bin/mailman/listinfo/users
_______________________________________________
Kamailio (OpenSER) - Users mailing list
Users(a)lists.kamailio.org <mailto:Users@lists.kamailio.org>
http://lists.kamailio.org/cgi-bin/mailman/listinfo/users
http://lists.openser-project.org/cgi-bin/mailman/listinfo/users
_______________________________________________
Kamailio (OpenSER) - Users mailing list
Users(a)lists.kamailio.org <mailto:Users@lists.kamailio.org>
------------------------------------------------------------------------
_______________________________________________
Kamailio (OpenSER) - Users mailing list
Users(a)lists.kamailio.org