Hello Federico,

did you managed to create a pull request for the this extension?

Thanks and regards,

Henning

--

Henning Westerholt – https://skalatan.de/blog/

Kamailio services – https://gilawa.com

From: sr-users <sr-users-bounces@lists.kamailio.org> On Behalf Of José Lopes
Sent: Friday, May 15, 2020 8:12 PM
To: Daniel-Constantin Mierla <miconda@gmail.com>; Kamailio (SER) - Users Mailing List <sr-users@lists.kamailio.org>
Subject: Re: [SR-Users] 488 Not Acceptable Here when remove codecs with rtcp-fb

Hello,

I can test the patch and give you feedback.

Best Regards,

Jose

On Mon, May 11, 2020 at 12:18 PM Daniel-Constantin Mierla <miconda@gmail.com> wrote:

Hello,

sure, make a pull request for it.

To be easy to merge, here are some guidelines for contributions

  *
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#contributing-code-or-content

Cheers,
Daniel

On 11.05.20 12:48, Federico Santulli wrote:
> I did a patch over the SDPOPS module to do this.
>
> If needed I can push it over git.
>
> Kind regards.
>
> Federico Santulli
>
> NHM - S.R.L.
> Via Raffaello Sanzio, 88
> 81031 Aversa (CE)
> Italy
>
>
>> Il giorno 5 mag 2020, alle ore 15:55, José Lopes <jose.lopes@itcenter.com.pt> ha scritto:
>>
>> Hello,
>>
>> I am using KSR.sdpops.keep_codecs_by_name to remove some codecs.
>> When I make a call between two webrtc clients and I keep only VP8 video codec, the browser rejects the call with 488 Not Acceptable Here.
>>
>> I notice the attributes a=rtcp-fb: of codecs removed are kept.
>> I removed that attributes with:
>> KSR.textops.replace_body_atonce("a=rtcp-fb:1.*\n", "");
>> KSR.textops.replace_body_atonce("a=rtcp-fb:98.*\n", "");
>> And the call worked.
>>
>> There is another way to remove these attributes related to codec name?
>> Or is it possible to get the ids of the codecs with dynamic payload type numbers from SDP?
>>
>> Thanks for your attention.
>>
>> Best regards,
>> Jose Lopes
>>
>>
>> _______________________________________________
>> Kamailio (SER) - Users Mailing List
>> sr-users@lists.kamailio.org
>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
>
> _______________________________________________
> Kamailio (SER) - Users Mailing List
> sr-users@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Funding: https://www.paypal.me/dcmierla


_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users