Hi Luis,

for my own clarification, the call-id attribute is not in the static body:

#define DIALOGINFO_EMPTY_BODY "<dialog-info>\
<dialog id=\"615293b33c62dec073e05d9421e9f48b\" direction=\"recipient\">\
<state>terminated</state>\
</dialog>\
</dialog-info>"

I couldn't spot where it would be added later... is id attribute enough, or I missed the point where call-id is set?

Cheers,
Daniel

On 28/08/15 15:45, Luis Azedo wrote:
Hi,

the change to include the call-id / dialog-id was precisely because of phones like Grandstream, and as Daniel mentioned, its only in 4.3 / master.
to fix this in 4.2, we need to backport the commit that adds it.
or..., you could use 4.3

Cheers
Luis


From: Daniel-Constantin Mierla [miconda@gmail.com]
Sent: Friday, August 28, 2015 6:15 AM
To: Kamailio (SER) - Users Mailing List; evoip@ukr.net
Cc: Luis Azedo
Subject: Re: [SR-Users] presence_dialoginfo- first NOTIFY - force_dummy_dialog

Hello,

first, I see:

<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1" ΥΘ state="full" entity="sip:9095@10.60.1.3">

Is the 'yx' in the line above appearing or just a result of adjusting what you pasted in the email?

I thought Kazoo in using stock kamailio, in fact Luis (cc-ed) from Kazoo pushed a patch to kamailio adding id to dialog tag (commit f12f243e39c840b1306bf376c49ef4dab9e7564f), but I don't see the call-id there, maybe is added when processing later.

Checking the source code, the id in dialog tag is only in kamailio 4.3, which I guess is what last kazoo is using. Perhaps the patch can be backported to branch 4.2, it is not a big change there.

Cheers,
Daniel

On 28/08/15 14:54, evoip@ukr.net wrote:
Hello,
we use Kamailio 4.2 with Presence_DIALOGINFO module for BLF notifications (blinking lamps on phone panel).

Since version 4.1 Kamailio has a new module parametr " modparam("presence_dialoginfo", "force_dummy_dialog", 1)" - this option generate first NOTIFY to Subscribed phone (without PUBLISH message) and it's lamps became GREEN ( <state>terminated</state>).

Without this module parametr the first NOTIFY won't be sent to phone and lamps will stay turned off until first PUBLISH will be handled by presence server.

The first NOTIFY sip message with xml body look like this:


NOTIFY sip:1005@22.22.22.22:1120 SIP/2.0.
To: <sip:1005@11.11.11.11>;tag=867246696.
From: <sip:9095@11.11.11.11>;tag=495949c4c25d687c77ca707bd10a0818-5171.
CSeq: 2 NOTIFY.
Call-ID: 662126467-5060-6@BJC.BGI.E.CDD.
Route: <sip:10.60.1.3;r2=on;lr=on>, <sip:11.11.11.11;r2=on;lr=on>.
Content-Length: 272.
User-Agent: kamailio (4.2.3 (x86_64/linux)).
Max-Forwards: 70.
Event: dialog.
Subscription-State: active;expires=600.
Content-Type: application/dialog-info+xml.
.
<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1" ΥΘ state="full" entity="sip:9095@10.60.1.3">
šššš <dialogš direction="recipient">
ššš ššš <state>terminated</state>
ššš </dialog>
</dialog-info>

Especially pay attention on XML body.


But for some SIP phones this xml body with state = terminated is not enough to turn the BLF lamp on. (for example Grandstream phones).
It requires one more or two more fields: "dialog id", "call-id".

<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="28"ššššššššš state="full" entity="sip:9093@10.60.1.3">
š <dialog id="830b4fd4-c75d-1233-ca9f-0050569560f4" call-id="830b4fd4-c75d-1233-ca9f-0050569560f4" direction="recipient">
ššš <state>terminated</state>
š </dialog>
</dialog-info>



The question is how to modify this first NOTIFY XML body message to add "dialog id" and "call-id" to </dialog>.
For example latest Kamailio Kazoo fixed that already. :)





Kind Regards
Ewgeny













_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Book: SIP Routing With Kamailio - http://www.asipto.com

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Book: SIP Routing With Kamailio - http://www.asipto.com