On 02-03 14:04, Marian Dumitru wrote:
Hi Jan,
So some URI checking is required and indeed, if you want to allow clients to perform that magic you mentioned, the checking should be done after extracting the URIs from usrloc. But should be very clear if a contact URI can or cannot be involved in SIP signaling - used for forwarding. One note here - it's interesting what will be the impact on nathelper when it will start doing NAT ping to non-SIP URIs :-).
When fix_nated_register is used then napinger will use the URI from received column of location table, that URI will be sip: so it should work fine.
If the received column is empty then NAT pinger will be given the real contact -- which would contain http scheme in this case -- and it would fail parsin the URI. nat_pinger would probably generate lots of error messages to syslog in this case :-).
Anyhow, the best place to do the checking is before t_relay(). If you do th filtering immediately after lookup(), you will loose the Redirect Server functionality.
Yes, unless there are some other functions in between which would need to parse the Request-URI (parsing would fail).
Jan.