RE: [Users] Domain: is_from_local() is case sensitive in caching mode.

Hello, I have been looking into the code. strncasecmp does case insensitive comparison, so this part is correct. My guess is that the hash function should use the lowercase domain. In my case I have in the domain table "i-call.gr" and

If the From header is ....(a)i-Call.gr then is_from_local()

(in caching mode). I hope this helps George >-----Original Message----- >From: Bogdan-Andrei Iancu [mailto:bogdan@voice-system.ro] >Sent: Monday, March 13, 2006 11:32 AM >To: Papadopoulos Georgios >Cc: daniel(a)voice-system.ro; users(a)openser.org; Juha Heinanen >Subject: Re: [Users] Domain: is_from_local() is case sensitive in >caching mode. > >Hi Georgios, > >indeed, the search through the cache is done case sensitive via >strncasesmp(). > >Juha, souldn't the domain matching be case insensitive? > >regards, >bogdan > > >Georgios Papadopoulos wrote: > > > >>I am pretty sure (I am using OpenSER 1.0.0). >>What about the part where the table is cached into memory?

>>select lower(domain) from domain? I tried briefly to find >> >> >the relevant > > >>piece of code but I couldn't. >> >>George >> >> >> >> >> >> >>>-----Original Message----- >>>From: Daniel-Constantin Mierla [mailto:daniel@voice-system.ro] >>>Sent: Saturday, March 11, 2006 3:50 PM >>>To: Papadopoulos Georgios >>>Cc: users(a)openser.org >>>Subject: Re: [Users] Domain: is_from_local() is case sensitive in >>>caching mode. >>> >>>Hello, >>> >>>On 03/10/06 17:51, Papadopoulos Georgios wrote: >>> >>> >>> >>> >>>>Hello, >>>> >>>>I have noticed that is_from_local in the Domain module is >>>>case-sensitive if the module is in caching mode. In >>>> >>>> >>>> >>>> >>>non-caching mode >>> >>> >>> >>> >>>>it is case insensitive. >>>>Could this be fixed in the future? >>>> >>>> >>>> >>>> >>>> >>>are you sure? I was looking in the sources and the comparison is >>>case-insensitive. >>> >>>Cheers, >>>Daniel >>> >>> >>> >>> >>> >>>>thank you >>>> >>>>George >>>> >>>>Disclaimer >>>>The information in this e-mail and any attachments is >>>> >>>> >>>> >>>> >>>confidential. It is intended solely for the attention and >>> >>> >use of the > > >>>named addressee(s). If you are not the intended recipient, >>> >>> >or person > > >>>responsible for delivering this information to the intended >>> >>> >recipient, > > >>>please notify the sender immediately. Unless you are the intended >>>recipient or his/her representative you are not

>>>must not, read, copy, distribute, use or retain this

Disclaimer The information in this e-mail and any attachments is