sr-dev July 2010

sr-dev@lists.kamailio.org

29 participants
223 discussions

[ openser-Patches-3035780 ] Let pua use the configured outboudn proxy in all cases
by SourceForge.net 30 Jul '10

30 Jul '10

Patches item #3035780, was opened at 2010-07-28 10:07 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035780&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Alex Hermann (axlh) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Let pua use the configured outboudn proxy in all cases Initial Comment: pua wasn't using the outbound proxy on updates ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-30 21:28 Message: Thanks! Patch committed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035780&group_…

1 0

SF.net SVN: openser:[6038] branches/1.5/modules/pua/pua.c
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Revision: 6038 http://openser.svn.sourceforge.net/openser/?rev=6038&view=rev Author: miconda Date: 2010-07-30 18:27:51 +0000 (Fri, 30 Jul 2010) Log Message: ----------- - use the outbound proxy on updates - patch by Alex Hermann, SF#3035780 Modified Paths: -------------- branches/1.5/modules/pua/pua.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

[ openser-Patches-3035382 ] Fix transformation tobody.params
by SourceForge.net 30 Jul '10

30 Jul '10

Patches item #3035382, was opened at 2010-07-27 19:11 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Alex Hermann (axlh) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Fix transformation tobody.params Initial Comment: The transofrmation tobody.params can't handle quoted parameters well. If the last parameter is quoted, the output of the transofrmation is truncated by 2 characters.. Attached patch fixes this. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-30 21:21 Message: Thanks! Patches committed on git master branch and 1.5 for now. ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2010-07-28 09:42 Message: Well, not a good start :( I split the patch into 2 parts. Part 1: Fix a off-by-one bug in parsing quoted parameters. The parameter value is shortened by 1 character. Part 2: Fix the tobody.params tranformation when the last paremeter has a quoted value. I found another solution: Just assume the parameter list ends on the end of the header line that gets pushed to the parser. Seems to work just as well, and prevents adjusting the rest of the code (tm). ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-27 23:25 Message: I reverted the commit on 1.5 branch - it was incomplete as the compilation got broken. Also, there should not be any commit on the trunk branch, the devel version is now on GIT repository hosted at git.sip-router.org. The bug tracker in use is as well by sip-router.org: http://sip-router.org/tracker Back to issue, apart of breaking the compilation, it could be a solution to store the hook for start of parameters and the length, but I didn't understand why you changed the len of quoted value. Moreover, there are other places that needs to be updated when the to_body structure is updated with new attributes storing pointers, like cloning for TM transactions. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_…

1 0

SF.net SVN: openser:[6037] branches/1.5/modules/pv/pv_trans.c
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Revision: 6037 http://openser.svn.sourceforge.net/openser/?rev=6037&view=rev Author: miconda Date: 2010-07-30 18:20:27 +0000 (Fri, 30 Jul 2010) Log Message: ----------- - fixed tobody.params transformation - len was wrong when having quoted parameters - patch by Alex Hermann, closes SF#3035382 Modified Paths: -------------- branches/1.5/modules/pv/pv_trans.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

SF.net SVN: openser:[6036] branches/1.5/parser/parse_to.c
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Revision: 6036 http://openser.svn.sourceforge.net/openser/?rev=6036&view=rev Author: miconda Date: 2010-07-30 18:18:33 +0000 (Fri, 30 Jul 2010) Log Message: ----------- - fix off-by-one bug for quoted parameter values in parse_to - patch by Alex Hermann, SF#3035382 Modified Paths: -------------- branches/1.5/parser/parse_to.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

git:master: pv: fixed tobody.params transformation
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Module: sip-router Branch: master Commit: 6cc5f8ec90db48483d644430bc2628356833fc1e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6cc5f8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 20:15:13 2010 +0200 pv: fixed tobody.params transformation - len was wrong when having quoted parameters - patch by Alex Hermann, closes SF#3035382 --- modules_k/pv/pv_trans.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/modules_k/pv/pv_trans.c b/modules_k/pv/pv_trans.c index 5d60d04..e568ddb 100644 --- a/modules_k/pv/pv_trans.c +++ b/modules_k/pv/pv_trans.c @@ -1033,12 +1033,8 @@ int tr_eval_tobody(struct sip_msg *msg, tr_param_t *tp, int subtype, if(_tr_tobody.param_lst!=NULL) { val->rs.s = _tr_tobody.param_lst->name.s; - if(_tr_tobody.last_param->value.s!=NULL) - val->rs.len = _tr_tobody.last_param->value.s - +_tr_tobody.last_param->value.len - val->rs.s; - else - val->rs.len = _tr_tobody.last_param->name.s - +_tr_tobody.last_param->name.len - val->rs.s; + val->rs.len = _tr_tobody_str.s + _tr_tobody_str.len + - val->rs.s; } else val->rs = _tr_empty; break;

1 0

git:master: core: fix parsing quoted paramers in To header
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Module: sip-router Branch: master Commit: 8593bc83c748835c6132eaa678064a2466316ae7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8593bc8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 20:07:45 2010 +0200 core: fix parsing quoted paramers in To header - fix off-by-one bug for quoted parameter values in parse_to - patch by Alex Hermann, SF#3035382 --- parser/parse_to.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/parser/parse_to.c b/parser/parse_to.c index 8dbaacf..8bfdca7 100644 --- a/parser/parse_to.c +++ b/parser/parse_to.c @@ -241,7 +241,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, status = PARA_VALUE_QUOTED; break; case PARA_VALUE_QUOTED: - param->value.len=tmp-param->value.s-1 ; + param->value.len=tmp-param->value.s; add_param( param , to_b ); status = E_PARA_VALUE; break;

1 0

[ openser-Patches-1769555 ] DISPATCH : weighted dispatching
by SourceForge.net 30 Jul '10

30 Jul '10

Patches item #1769555, was opened at 2007-08-07 20:29 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1769555&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel >Status: Closed >Resolution: Fixed Priority: 2 Private: No Submitted By: Emmanuel BUU (neutrino38) Assigned to: Daniel-Constantin Mierla (miconda) Summary: DISPATCH : weighted dispatching Initial Comment: The proposed patch enhances the DISPATCH modules. It enables the specification of weight for each destination. For instance if destination.list contains 1 proxy1:5060 50 1 proxy2:5060 20 1 proxy3;5060 30 50% of calls will be dispatched to proxy1, 20% of calls will be disptached to proxy2 30% to proxy3 ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-30 20:51 Message: Git master branch has weight based load balancing in dispatcher module. ---------------------------------------------------------------------- Comment By: Emmanuel BUU (neutrino38) Date: 2007-10-05 17:59 Message: Logged In: YES user_id=1862563 Originator: YES As you wish ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2007-10-05 17:34 Message: Logged In: YES user_id=1246013 Originator: NO Not being sure that this enhancement will preserve old behavior when having same weight for all destination, I postpone the integration for the next release, as carrierroute module satisfy the proposed enhancement. ---------------------------------------------------------------------- Comment By: Emmanuel BUU (neutrino38) Date: 2007-08-30 01:07 Message: Logged In: YES user_id=1862563 Originator: YES Ok I submitted a patch based on trunk version. It compiles but it is not tested yet although it is based on the same algorithm than the previous one. I updated the DB schema as well. Note: I discovered the existence of the CARRIERROUTE module that basically makes much more than this modified DISPATCH. THis is great. Emmanuel BUU http://www.ives.fr/ ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2007-08-10 10:20 Message: Logged In: YES user_id=1246013 Originator: NO Please provide the patch against devel version, there is support for storing destination list in database as well. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1769555&group_…

1 0

[ openser-Patches-3035778 ] Fix registrar when fetching binding for unregistered user
by SourceForge.net 30 Jul '10

30 Jul '10

Patches item #3035778, was opened at 2010-07-28 10:04 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Alex Hermann (axlh) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Fix registrar when fetching binding for unregistered user Initial Comment: When an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-30 20:48 Message: Patch committed on git master branch and svn 1.5. Thanks! ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2010-07-30 12:31 Message: Reopened as it's clear now the purpose of this patch. ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2010-07-30 11:59 Message: Sorry, the patch is already a bit old and i got the description wrong. The patch is actually an addendum to bug 2851214. It makes sure kamailio doesn't return someone else's contact in case there is a failure. The contacts are stored in a global variable and needs to be cleared if it isn't filled with valid contacts. Please reopen. ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2010-07-28 13:29 Message: A "Contact" header with no value is *not* valid according to SIP BNF grammar so in case a UA fetches its bindging and there are not bindings then the registrar should reply a 200 without "Contact" header. Taking this into account I suspect that this patch is wrong. As a side note, there is a bug/issue open for RFC 3261 related to this topic as the RFC 3261 seems to state that the registrar should reply a 200 with a Contact header containing all the bindings. But it's clear (also in the RFC bug report) that the BNF grammar cannot be violated so there should be NO Contact header if there are no bindings. I close this bug as it not valid. However as Daniel said please use http://sip-router.org/tracker/ for future reports :) ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-28 10:07 Message: Can you use the tracker at sip-router.org? http://sip-router.org/tracker/ SF tracker should not be used anymore for new items. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_…

1 0

SF.net SVN: openser:[6035] branches/1.5/modules
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Revision: 6035 http://openser.svn.sourceforge.net/openser/?rev=6035&view=rev Author: miconda Date: 2010-07-30 17:47:03 +0000 (Fri, 30 Jul 2010) Log Message: ----------- - backport git commit 776d94 - when an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. - closes SF#3035778, patch by Alex Hermann Modified Paths: -------------- branches/1.5/modules/registrar/save.c Property Changed: ---------------- branches/1.5/modules/pv/pv_shv.c branches/1.5/modules/pv/pv_shv.h branches/1.5/modules/pv/pv_svar.c branches/1.5/modules/pv/pv_svar.h branches/1.5/modules/pv/pv_trans.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2010