sr-dev July 2010

sr-dev@lists.kamailio.org

29 participants
223 discussions

git:master: registrar(k): reset local contact holder
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Module: sip-router Branch: master Commit: 776d941bef2e97089493a896bf0b57607078c52d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=776d941… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 19:40:50 2010 +0200 registrar(k): reset local contact holder - when an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. - closes SF#3035778, patch by Alex Hermann --- modules_k/registrar/save.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules_k/registrar/save.c b/modules_k/registrar/save.c index d22def0..9955034 100644 --- a/modules_k/registrar/save.c +++ b/modules_k/registrar/save.c @@ -457,6 +457,8 @@ static inline int insert_contacts(struct sip_msg* _m, contact_t* _c, if (r->contacts) build_contact(r->contacts); ul.release_urecord(r); + } else { /* No contacts found */ + build_contact(NULL); } #ifdef USE_TCP

1 0

git:master: presence_xml: xml PV moved to xmlops module
by Daniel-Constantin Mierla 30 Jul '10

30 Jul '10

Module: sip-router Branch: master Commit: 5d5f342267e6ca70f2af7722e6179fd19ec78945 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5d5f342… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 29 20:23:19 2010 +0200 presence_xml: xml PV moved to xmlops module --- modules_k/presence_xml/README | 36 +- modules_k/presence_xml/doc/presence_xml_admin.xml | 15 +- modules_k/presence_xml/presence_xml.c | 9 +- modules_k/presence_xml/pv_xml.c | 550 --------------------- modules_k/presence_xml/pv_xml.h | 38 -- 5 files changed, 13 insertions(+), 635 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=5d5…

2 3

[ openser-Patches-3035778 ] Fix registrar when fetching binding for unregistered user
by SourceForge.net 30 Jul '10

30 Jul '10

Patches item #3035778, was opened at 2010-07-28 09:04 Message generated for change (Comment added) made by ibc_sf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Open >Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Fix registrar when fetching binding for unregistered user Initial Comment: When an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. ---------------------------------------------------------------------- >Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2010-07-30 11:31 Message: Reopened as it's clear now the purpose of this patch. ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2010-07-30 10:59 Message: Sorry, the patch is already a bit old and i got the description wrong. The patch is actually an addendum to bug 2851214. It makes sure kamailio doesn't return someone else's contact in case there is a failure. The contacts are stored in a global variable and needs to be cleared if it isn't filled with valid contacts. Please reopen. ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2010-07-28 12:29 Message: A "Contact" header with no value is *not* valid according to SIP BNF grammar so in case a UA fetches its bindging and there are not bindings then the registrar should reply a 200 without "Contact" header. Taking this into account I suspect that this patch is wrong. As a side note, there is a bug/issue open for RFC 3261 related to this topic as the RFC 3261 seems to state that the registrar should reply a 200 with a Contact header containing all the bindings. But it's clear (also in the RFC bug report) that the BNF grammar cannot be violated so there should be NO Contact header if there are no bindings. I close this bug as it not valid. However as Daniel said please use http://sip-router.org/tracker/ for future reports :) ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-28 09:07 Message: Can you use the tracker at sip-router.org? http://sip-router.org/tracker/ SF tracker should not be used anymore for new items. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_…

1 0

Cleaning up my patch queue
by Alex Hermann 30 Jul '10

30 Jul '10

Hello all, i'm cleaning my patch queue and have pushed all patched that might be relevant to others to the tracker on sourceforge. To prevent mishaps like my previous commit, i would like an ACK or NACK on each patch before i commit them. These are all meant for 1.5, but most of them apply to 3.0 too. Thanks, -- Alex Hermann SpeakUp BV

2 3

[ openser-Patches-3035778 ] Fix registrar when fetching binding for unregistered user
by SourceForge.net 30 Jul '10

30 Jul '10

Patches item #3035778, was opened at 2010-07-28 09:04 Message generated for change (Comment added) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Closed Resolution: Invalid Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Fix registrar when fetching binding for unregistered user Initial Comment: When an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2010-07-30 10:59 Message: Sorry, the patch is already a bit old and i got the description wrong. The patch is actually an addendum to bug 2851214. It makes sure kamailio doesn't return someone else's contact in case there is a failure. The contacts are stored in a global variable and needs to be cleared if it isn't filled with valid contacts. Please reopen. ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2010-07-28 12:29 Message: A "Contact" header with no value is *not* valid according to SIP BNF grammar so in case a UA fetches its bindging and there are not bindings then the registrar should reply a 200 without "Contact" header. Taking this into account I suspect that this patch is wrong. As a side note, there is a bug/issue open for RFC 3261 related to this topic as the RFC 3261 seems to state that the registrar should reply a 200 with a Contact header containing all the bindings. But it's clear (also in the RFC bug report) that the BNF grammar cannot be violated so there should be NO Contact header if there are no bindings. I close this bug as it not valid. However as Daniel said please use http://sip-router.org/tracker/ for future reports :) ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-28 09:07 Message: Can you use the tracker at sip-router.org? http://sip-router.org/tracker/ SF tracker should not be used anymore for new items. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_…

1 0

git:master: xmlops: new module for xml operations
by Daniel-Constantin Mierla 29 Jul '10

29 Jul '10

Module: sip-router Branch: master Commit: e9438550e076de32fc0ebd51c296efba099d82c2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e943855… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 29 20:37:50 2010 +0200 xmlops: new module for xml operations - implements $xml(name=>spec) pseudo-variable (previously was in presence_xml) - new parameter buf_size to control the max size of internal buffer for xml document management --- modules/xmlops/Makefile | 19 ++ modules/xmlops/README | 80 ++++++ modules/xmlops/doc/Makefile | 4 + modules/xmlops/doc/functions.xml | 29 ++ modules/xmlops/doc/params.xml | 41 +++ modules/xmlops/doc/xmlops.xml | 66 +++++ modules/xmlops/pv_xml.c | 550 ++++++++++++++++++++++++++++++++++++++ modules/xmlops/pv_xml.h | 38 +++ modules/xmlops/xmlops_mod.c | 74 +++++ 9 files changed, 901 insertions(+), 0 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e94…

1 0

SF.net SVN: openser:[6034] branches/1.5/modules/sst/sst_handlers.c
by Timo Reimann 29 Jul '10

29 Jul '10

Revision: 6034 http://openser.svn.sourceforge.net/openser/?rev=6034&view=rev Author: timoreimann Date: 2010-07-29 17:15:11 +0000 (Thu, 29 Jul 2010) Log Message: ----------- modules/sst: Setting AVPs from integer values requires the PV_TYPE_INT flag to be set. Modified Paths: -------------- branches/1.5/modules/sst/sst_handlers.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

git:kamailio_3.0: modules_k/sst: Setting AVPs from integer values requires the
by Timo Reimann 29 Jul '10

29 Jul '10

Module: sip-router Branch: kamailio_3.0 Commit: 0657d12cf2a1788c8d77d6495dd93e84d0f83c83 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0657d12… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Jul 29 19:09:51 2010 +0200 modules_k/sst: Setting AVPs from integer values requires the PV_TYPE_INT flag to be set. (cherry picked from commit 61c4a93486fd3d215efb8d045c7415d752d3f057) --- modules_k/sst/sst_handlers.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/sst/sst_handlers.c b/modules_k/sst/sst_handlers.c index 43f1c09..68a91ba 100644 --- a/modules_k/sst/sst_handlers.c +++ b/modules_k/sst/sst_handlers.c @@ -834,7 +834,7 @@ static int set_timeout_avp(struct sip_msg *msg, unsigned int value) rtn = 0; } else { /* AVP not found or non-INT value -> add a new one*/ - pv_val.flags = PV_VAL_INT; + pv_val.flags = PV_VAL_INT|PV_TYPE_INT; pv_val.ri = value; if (timeout_avp->setf(msg,&timeout_avp->pvp,EQ_T,&pv_val)!=0) { LM_ERR("failed to set new dialog timeout value\n");

1 0

git:master: modules_k/sst: Setting AVPs from integer values requires the
by Timo Reimann 29 Jul '10

29 Jul '10

Module: sip-router Branch: master Commit: 61c4a93486fd3d215efb8d045c7415d752d3f057 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=61c4a93… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Jul 29 19:09:51 2010 +0200 modules_k/sst: Setting AVPs from integer values requires the PV_TYPE_INT flag to be set. --- modules_k/sst/sst_handlers.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/sst/sst_handlers.c b/modules_k/sst/sst_handlers.c index 5f80f63..6a17c37 100644 --- a/modules_k/sst/sst_handlers.c +++ b/modules_k/sst/sst_handlers.c @@ -834,7 +834,7 @@ static int set_timeout_avp(struct sip_msg *msg, unsigned int value) rtn = 0; } else { /* AVP not found or non-INT value -> add a new one*/ - pv_val.flags = PV_VAL_INT; + pv_val.flags = PV_VAL_INT|PV_TYPE_INT; pv_val.ri = value; if (timeout_avp->setf(msg,&timeout_avp->pvp,EQ_T,&pv_val)!=0) { LM_ERR("failed to set new dialog timeout value\n");

1 0

git:master: textopsx: new module for text operations
by Daniel-Constantin Mierla 29 Jul '10

29 Jul '10

Module: sip-router Branch: master Commit: a4e0d01788f71e560b1a19a3007a5c29f9150e2c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a4e0d01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 29 18:59:47 2010 +0200 textopsx: new module for text operations - it collects functions that have no kamailio or ser specific dependecies - moved here: msg_apply_changes() and change_reply_status() --- modules/textopsx/Makefile | 16 +++ modules/textopsx/README | 71 +++++++++++ modules/textopsx/doc/Makefile | 4 + modules/textopsx/doc/functions.xml | 76 ++++++++++++ modules/textopsx/doc/textopsx.xml | 43 +++++++ modules/textopsx/textopsx.c | 226 ++++++++++++++++++++++++++++++++++++ 6 files changed, 436 insertions(+), 0 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=a4e…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2010